From: Eric Biggers <ebiggers@kernel.org>
To: Gary R Hook <ghook@amd.com>
Cc: "Hook, Gary" <Gary.Hook@amd.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>
Subject: Re: [PATCH v2] crypto: ccp - memset structure fields to zero before reuse
Date: Wed, 10 Jul 2019 13:34:29 -0700 [thread overview]
Message-ID: <20190710203428.GC83443@gmail.com> (raw)
In-Reply-To: <2875285f-d438-667e-52d9-801124ffba88@amd.com>
On Wed, Jul 10, 2019 at 03:59:05PM +0000, Gary R Hook wrote:
> On 7/9/19 8:57 PM, Eric Biggers wrote:
> > On Wed, Jul 10, 2019 at 12:09:22AM +0000, Hook, Gary wrote:
> >> The AES GCM function reuses an 'op' data structure, which members
> >> contain values that must be cleared for each (re)use.
> >>
> >> This fix resolves a crypto self-test failure:
> >> alg: aead: gcm-aes-ccp encryption test failed (wrong result) on test vector 2, cfg="two even aligned splits"
> >>
> >> Fixes: 36cf515b9bbe ("crypto: ccp - Enable support for AES GCM on v5 CCPs")
> >>
> >> Signed-off-by: Gary R Hook <gary.hook@amd.com>
> >
> > FYI, with this patch applied I'm still seeing another test failure:
> >
> > [ 2.140227] alg: aead: gcm-aes-ccp setauthsize unexpectedly succeeded on test vector "random: alen=264 plen=161 authsize=6 klen=32"; expected_error=-22
> >
> > Are you aware of that one too, and are you planning to fix it?
> >
> > - Eric
> >
>
> I just pulled the latest on the master branch of cryptodev-2.6, built,
> booted, and loaded our module. And I don't see that error. It must be new?
Did you have CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled? This failure was with a
test vector that was generated randomly by the fuzz tests, so
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y is needed to reproduce it.
You probably just need to update ccp_aes_gcm_setauthsize() to validate the
authentication tag size.
>
> In any event, if a test failure occurs, it gets fixed.
>
Good to hear.
- Eric
next prev parent reply other threads:[~2019-07-10 20:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 0:09 [PATCH v2] crypto: ccp - memset structure fields to zero before reuse Hook, Gary
2019-07-10 1:57 ` Eric Biggers
2019-07-10 15:59 ` Gary R Hook
2019-07-10 20:34 ` Eric Biggers [this message]
2019-07-10 22:50 ` Gary R Hook
2019-07-11 0:46 ` Eric Biggers
2019-07-11 15:25 ` Gary R Hook
2019-07-12 2:20 ` Herbert Xu
2019-07-12 10:18 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710203428.GC83443@gmail.com \
--to=ebiggers@kernel.org \
--cc=Gary.Hook@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=davem@davemloft.net \
--cc=ghook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).