From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9253CC76195 for ; Mon, 15 Jul 2019 14:19:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BAA321530 for ; Mon, 15 Jul 2019 14:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563200394; bh=JeED2MLzVHRU380nfTU/LlGZeiefkXph35PBqEon+Kw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qhNArkhh0yMpuXozEdHvOe5VZbKkkxRJ8KRW+CHV4LI2qHwrBtEEFLJe1xtb/unmg DRn2Ry8MXN0YrUyp/cyzc7lLollKwWIwrwDVaE4oMMF9cbzruneJy6afjpW/b4w4dH t1a3IVp0T9DRehbMy5a7F6NlaSZBRT6Yh1qaKYtk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389697AbfGOOTs (ORCPT ); Mon, 15 Jul 2019 10:19:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:42124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389747AbfGOOTr (ORCPT ); Mon, 15 Jul 2019 10:19:47 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CBA9C206B8; Mon, 15 Jul 2019 14:19:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563200387; bh=JeED2MLzVHRU380nfTU/LlGZeiefkXph35PBqEon+Kw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jtospgeaaA1ZO4PDBbcO70T53T7Cg4oME1vZ12oJ8rddraGogxUF5pCndu5c60OEQ a7k4o4fcVOo7fLJHZiy9XxS/ekg26cDFWKCugFVpt4w6QfSh2z6OdmYHGZOQfmPABf nWUYq10w/mjXF8aSXgAYbI1KM+crtVhn65fYCYXw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Christophe Leroy , Herbert Xu , Sasha Levin , linux-crypto@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 034/158] crypto: talitos - Align SEC1 accesses to 32 bits boundaries. Date: Mon, 15 Jul 2019 10:16:05 -0400 Message-Id: <20190715141809.8445-34-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715141809.8445-1-sashal@kernel.org> References: <20190715141809.8445-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: Christophe Leroy [ Upstream commit c9cca7034b34a2d82e9a03b757de2485c294851c ] The MPC885 reference manual states: SEC Lite-initiated 8xx writes can occur only on 32-bit-word boundaries, but reads can occur on any byte boundary. Writing back a header read from a non-32-bit-word boundary will yield unpredictable results. In order to ensure that, cra_alignmask is set to 3 for SEC1. Signed-off-by: Christophe Leroy Fixes: 9c4a79653b35 ("crypto: talitos - Freescale integrated security engine (SEC) driver") Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/talitos.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index 027cb298888e..d2c02ad2cfd6 100644 --- a/drivers/crypto/talitos.c +++ b/drivers/crypto/talitos.c @@ -3210,7 +3210,10 @@ static struct talitos_crypto_alg *talitos_alg_alloc(struct device *dev, alg->cra_priority = t_alg->algt.priority; else alg->cra_priority = TALITOS_CRA_PRIORITY; - alg->cra_alignmask = 0; + if (has_ftr_sec1(priv)) + alg->cra_alignmask = 3; + else + alg->cra_alignmask = 0; alg->cra_ctxsize = sizeof(struct talitos_ctx); alg->cra_flags |= CRYPTO_ALG_KERN_DRIVER_ONLY; -- 2.20.1