Re: [PATCH 2/2] crypto: inside-secure: This fixes a mistake in a comment for XTS

[Antoine Tenart <antoine.tenart@bootlin.com>]

Hi Pascal,

On Tue, Jul 30, 2019 at 03:27:12PM +0200, Pascal van Leeuwen wrote:
> This fixes a copy-paste (and forgot to edit) mistake in a comment
> for XTS regarding the key length specification.
> 
> Signed-off-by: Pascal van Leeuwen <pvanleeuwen@verimatrix.com>

Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>

Thanks!
Antoine

> ---
>  drivers/crypto/inside-secure/safexcel_cipher.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers/crypto/inside-secure/safexcel_cipher.c
> index a30fdd5..56dc8f9 100644
> --- a/drivers/crypto/inside-secure/safexcel_cipher.c
> +++ b/drivers/crypto/inside-secure/safexcel_cipher.c
> @@ -1847,7 +1847,7 @@ struct safexcel_alg_template safexcel_alg_xts_aes = {
>  		.setkey = safexcel_skcipher_aesxts_setkey,
>  		.encrypt = safexcel_encrypt,
>  		.decrypt = safexcel_decrypt,
> -		/* Add 4 to include the 4 byte nonce! */
> +		/* XTS actually uses 2 AES keys glued together */
>  		.min_keysize = AES_MIN_KEY_SIZE * 2,
>  		.max_keysize = AES_MAX_KEY_SIZE * 2,
>  		.ivsize = 16,
> -- 
> 1.8.3.1
> 

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com