From: Eric Biggers <ebiggers@kernel.org>
To: Stephan Mueller <smueller@chronox.de>
Cc: Hans de Goede <hdegoede@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Andy Lutomirski <luto@kernel.org>,
linux-crypto@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [RFC 3/3] crypto/sha256: Build the SHA256 core separately from the crypto module
Date: Tue, 30 Jul 2019 09:03:36 -0700 [thread overview]
Message-ID: <20190730160335.GA27287@gmail.com> (raw)
In-Reply-To: <4384403.bebDo606LH@tauon.chronox.de>
On Tue, Jul 30, 2019 at 03:15:35PM +0200, Stephan Mueller wrote:
> Am Dienstag, 30. Juli 2019, 14:38:35 CEST schrieb Hans de Goede:
>
> Hi Hans,
>
> > From: Andy Lutomirski <luto@kernel.org>
> >
> > This just moves code around -- no code changes in this patch. This
> > wil let BPF-based tracing link against the SHA256 core code without
> > depending on the crypto core.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Signed-off-by: Andy Lutomirski <luto@kernel.org>
> > ---
> > crypto/Kconfig | 8 +
> > crypto/Makefile | 1 +
> > crypto/{sha256_generic.c => sha256_direct.c} | 103 +--------
>
> There is a similar standalone code present for SHA-1 or ChaCha20. However,
> this code lives in lib/.
>
> Thus, shouldn't the SHA-256 core code be moved to lib/ as well?
>
> Ciao
> Stephan
>
>
What's wrong with lib/sha256.c? It's already there.
- Eric
next prev parent reply other threads:[~2019-07-30 16:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 12:38 [RFC 0/3] Making a secure hash function avaiable during early boot? Hans de Goede
2019-07-30 12:38 ` [RFC 1/3] crypto/sha256: Factor out the parts of base API that don't use shash_desc Hans de Goede
2019-07-30 12:38 ` [RFC 2/3] crypto/sha256: Export a sha256_{init,update,final}_direct() API Hans de Goede
2019-07-30 12:38 ` [RFC 3/3] crypto/sha256: Build the SHA256 core separately from the crypto module Hans de Goede
2019-07-30 13:15 ` Stephan Mueller
2019-07-30 13:20 ` Hans de Goede
2019-07-30 16:03 ` Eric Biggers [this message]
2019-07-30 16:07 ` Hans de Goede
2019-07-30 20:07 ` Eric Biggers
2019-07-31 8:19 ` Hans de Goede
2019-07-31 10:57 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730160335.GA27287@gmail.com \
--to=ebiggers@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=hdegoede@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=luto@kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).