* [PATCH 3/5] crypto: Reduce default RT priority [not found] <20190801111348.530242235@infradead.org> @ 2019-08-01 11:13 ` Peter Zijlstra 2019-08-09 6:19 ` Herbert Xu 0 siblings, 1 reply; 2+ messages in thread From: Peter Zijlstra @ 2019-08-01 11:13 UTC (permalink / raw) To: mingo Cc: linux-kernel, peterz, Herbert Xu, David S. Miller, linux-crypto, Thomas Gleixner The crypto engine initializes its kworker thread to FIFO-99 (when requesting RT priority), reduce this to FIFO-50. FIFO-99 is the very highest priority available to SCHED_FIFO and it not a suitable default; it would indicate the crypto work is the most important work on the machine. Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: linux-crypto@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> --- crypto/crypto_engine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/crypto/crypto_engine.c +++ b/crypto/crypto_engine.c @@ -425,7 +425,7 @@ EXPORT_SYMBOL_GPL(crypto_engine_stop); */ struct crypto_engine *crypto_engine_alloc_init(struct device *dev, bool rt) { - struct sched_param param = { .sched_priority = MAX_RT_PRIO - 1 }; + struct sched_param param = { .sched_priority = MAX_RT_PRIO / 2 }; struct crypto_engine *engine; if (!dev) ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/5] crypto: Reduce default RT priority 2019-08-01 11:13 ` [PATCH 3/5] crypto: Reduce default RT priority Peter Zijlstra @ 2019-08-09 6:19 ` Herbert Xu 0 siblings, 0 replies; 2+ messages in thread From: Herbert Xu @ 2019-08-09 6:19 UTC (permalink / raw) To: Peter Zijlstra Cc: mingo, linux-kernel, David S. Miller, linux-crypto, Thomas Gleixner On Thu, Aug 01, 2019 at 01:13:51PM +0200, Peter Zijlstra wrote: > The crypto engine initializes its kworker thread to FIFO-99 (when > requesting RT priority), reduce this to FIFO-50. > > FIFO-99 is the very highest priority available to SCHED_FIFO and > it not a suitable default; it would indicate the crypto work is the > most important work on the machine. > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: linux-crypto@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > --- > crypto/crypto_engine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-09 6:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190801111348.530242235@infradead.org>
2019-08-01 11:13 ` [PATCH 3/5] crypto: Reduce default RT priority Peter Zijlstra
2019-08-09 6:19 ` Herbert Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).