From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E3AC19759 for ; Thu, 1 Aug 2019 12:46:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12CF220665 for ; Thu, 1 Aug 2019 12:46:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="vUXnXx5k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731374AbfHAMqZ (ORCPT ); Thu, 1 Aug 2019 08:46:25 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52098 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731349AbfHAMqY (ORCPT ); Thu, 1 Aug 2019 08:46:24 -0400 Received: by mail-wm1-f68.google.com with SMTP id 207so64537594wma.1 for ; Thu, 01 Aug 2019 05:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cZCY92RMfghZJsFP1Vz0w4UO7UoxBKe+hI+aMfOaKM8=; b=vUXnXx5kNtIFZ0huFPiV/HxhJIbQdYlkFxXwCPijUEreVyNC/1pxQMald0tr6/5oU+ Ku4JTGZOhL69MmV/Q5dbk4vWDah5/JPXEMYMNks43DojB8zmCbVBMLURc1fImEZ3YdI2 doKD9u7bejJ/UhT/GPcMTjZ3kZuOJbdM7J2rwAqwTZGpSbztlqyjT6hvwS7ltXOWjcBk TrrLVnQKDRIuXxZS6tfQvsGHNDhV8M+CJGdf4t3WAuO9zvRHvrl20GzPHvRRlfXh2a0J Ljef/yOoYB7o1JF7ZWTjXgMEN9MOgFo75dmzLwOg0n27FcmGHiQyvs9PyZVPgyw/6NZ0 KxRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cZCY92RMfghZJsFP1Vz0w4UO7UoxBKe+hI+aMfOaKM8=; b=qL8zg0Qao5J6XO5GXKV4pCV0G8oaQkCsVgulbyDKTui9hOxbMsHWEHSkZXHd2SpRAJ ui4v1q12rrkvgqfGNgBPKfJBwshkfxYAMTwxIL2j9nLbFHdAli8H+n9feSV3M4e8Hv1f hr4EUa7pvJ1iynsEnvn4X4lta+3RXZAnSSRz1GbZSYs0unpuOsZcSbHkih+H+0msRbGN NAoCoT0/Cb2B5AdUdTNdlznQtXDTbMQzDJueNaWD7EUxv+u17cgmmlFoa9k20D+Ihtzp BQxWKRzPXLoBGf5G2G+Al8GZuIXrMfuAe6t79TqF8/yY4NX1D0ibAykD23hcfJJLLWgF UEJQ== X-Gm-Message-State: APjAAAXn7DVQWJ8fT+b2BeHuUu62TlN3+zwvs0fmX8pNq2e1FbxJ3MAG Gms8EQvgG2pDPFGIhEtTUlKkNA== X-Google-Smtp-Source: APXvYqx/EB+krQbuHfDMiwKikaXaFO+7qwPqB2cAqkBDAaRdrKTmsFkpl+/WGtL6bOLXv0IkeDY/3A== X-Received: by 2002:a1c:3cc4:: with SMTP id j187mr110992050wma.36.1564663582722; Thu, 01 Aug 2019 05:46:22 -0700 (PDT) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id f70sm96317715wme.22.2019.08.01.05.46.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Aug 2019 05:46:21 -0700 (PDT) Date: Thu, 1 Aug 2019 14:46:18 +0200 From: LABBE Corentin To: Martin Blumenstingl Cc: davem@davemloft.net, herbert@gondor.apana.org.au, khilman@baylibre.com, mark.rutland@arm.com, robh+dt@kernel.org, devicetree@vger.kernel.org, baylibre-upstreaming@groups.io, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] crypto: amlogic: Add crypto accelerator for amlogic GXL Message-ID: <20190801124618.GA30316@Red> References: <1564083776-20540-1-git-send-email-clabbe@baylibre.com> <1564083776-20540-3-git-send-email-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Jul 27, 2019 at 02:17:38PM +0200, Martin Blumenstingl wrote: > Hi Corentin, > > it's great to see you working on this :) > > On Thu, Jul 25, 2019 at 9:45 PM Corentin Labbe wrote: > > > > This patch adds support for the amlogic GXL cryptographic offloader present > > on GXL SoCs. > > > > This driver supports AES cipher in CBC/ECB mode. > > > > Signed-off-by: Corentin Labbe > > --- > > drivers/crypto/Kconfig | 2 + > > drivers/crypto/Makefile | 1 + > > drivers/crypto/amlogic/Kconfig | 24 ++ > > drivers/crypto/amlogic/Makefile | 2 + > > drivers/crypto/amlogic/amlogic-cipher.c | 358 ++++++++++++++++++++++++ > > drivers/crypto/amlogic/amlogic-core.c | 326 +++++++++++++++++++++ > > drivers/crypto/amlogic/amlogic.h | 172 ++++++++++++ > > 7 files changed, 885 insertions(+) > > create mode 100644 drivers/crypto/amlogic/Kconfig > > create mode 100644 drivers/crypto/amlogic/Makefile > > create mode 100644 drivers/crypto/amlogic/amlogic-cipher.c > > create mode 100644 drivers/crypto/amlogic/amlogic-core.c > > create mode 100644 drivers/crypto/amlogic/amlogic.h > there are two different crypto IPs on Amlogic SoCs: > - GXL and newer use the "BLKMV" crypto IP > - GXBB, Meson8/Meson8b/Meson8m2 (and probably older SoCs) use the > "NDMA" crypto IP > I believed it was the opposite. (BLKMV the older, NDMA the newer) Anyway, on the datasheet I found (s905d), neither NDMA or BLKMV is mentioned, it is just called Crypto Engine. So I think GXL is the best choice. > personally I think it makes sense to either have the IP name (blkmv) > or SoC name (GXL) in the file or directory names as well as being > consistent with that in the Kconfig option names Ok I will rename files to amlogic-gxl-xxx Thanks