From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Pascal van Leeuwen <pascalvanl@gmail.com>
Cc: linux-crypto@vger.kernel.org, antoine.tenart@bootlin.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
Subject: Re: [PATCHv3 4/4] crypto: inside-secure - add support for using the EIP197 without vendor firmware
Date: Mon, 5 Aug 2019 11:07:25 +0200 [thread overview]
Message-ID: <20190805090725.GH14470@kwain> (raw)
In-Reply-To: <1564586959-9963-5-git-send-email-pvanleeuwen@verimatrix.com>
Hi Pascal,
Just a small comment below,
On Wed, Jul 31, 2019 at 05:29:19PM +0200, Pascal van Leeuwen wrote:
>
> - /* Release engine from reset */
> - val = readl(EIP197_PE(priv) + ctrl);
> - val &= ~EIP197_PE_ICE_x_CTRL_SW_RESET;
> - writel(val, EIP197_PE(priv) + ctrl);
> + for (pe = 0; pe < priv->config.pes; pe++) {
> + base = EIP197_PE_ICE_SCRATCH_RAM(pe);
> + pollcnt = EIP197_FW_START_POLLCNT;
> + while (pollcnt &&
> + (readl_relaxed(EIP197_PE(priv) + base +
> + pollofs) != 1)) {
> + pollcnt--;
You might want to use readl_relaxed_poll_timeout() here, instead of a
busy polling.
Thanks,
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-08-05 9:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 15:29 [PATCHv3 0/4] crypto: inside-secure - broaden driver scope Pascal van Leeuwen
2019-07-31 15:29 ` [PATCHv3 1/4] crypto: inside-secure - make driver selectable for non-Marvell hardware Pascal van Leeuwen
2019-08-05 8:04 ` Antoine Tenart
2019-07-31 15:29 ` [PATCHv3 2/4] crypto: inside-secure - Remove redundant algo to engine mapping code Pascal van Leeuwen
2019-08-05 7:51 ` Antoine Tenart
2019-07-31 15:29 ` [PATCHv3 3/4] crypto: inside-secure - add support for PCI based FPGA development board Pascal van Leeuwen
2019-08-05 8:36 ` Antoine Tenart
2019-08-05 8:47 ` Pascal Van Leeuwen
2019-08-05 9:09 ` Antoine Tenart
2019-08-05 9:49 ` Pascal Van Leeuwen
2019-07-31 15:29 ` [PATCHv3 4/4] crypto: inside-secure - add support for using the EIP197 without vendor firmware Pascal van Leeuwen
2019-08-05 9:07 ` Antoine Tenart [this message]
2019-08-05 9:48 ` Pascal Van Leeuwen
2019-08-05 9:54 ` Antoine Tenart
2019-08-05 10:12 ` Pascal Van Leeuwen
2019-08-05 12:43 ` Antoine Tenart
2019-08-05 13:02 ` Pascal Van Leeuwen
2019-08-05 13:12 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805090725.GH14470@kwain \
--to=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=pascalvanl@gmail.com \
--cc=pvanleeuwen@verimatrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).