From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5713C41514 for ; Sat, 17 Aug 2019 05:13:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CA2621773 for ; Sat, 17 Aug 2019 05:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566018803; bh=kZh/mBQKvBcCKVRcP4EwaxzK6sS4usQe5ZFCButursw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yGR2rPvl+3vKh5IFHyx/fP+xVL5kH8GXf4L7lGWgH98yJGvsWbKP9UOjvlbdFioUr KebwSZY4bQUafNSJXgvDyQKFzuCy0Jt7/1LRPSnYMpD11mSMLqXdneXM0Txbgj1yi5 cK1MitmGb68JNtS+s2K40dp+KcEIU29S4Pkm/WY0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725791AbfHQFNW (ORCPT ); Sat, 17 Aug 2019 01:13:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:55568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbfHQFNW (ORCPT ); Sat, 17 Aug 2019 01:13:22 -0400 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D9DA2133F; Sat, 17 Aug 2019 05:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566018800; bh=kZh/mBQKvBcCKVRcP4EwaxzK6sS4usQe5ZFCButursw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LW4xRrhQIFVOT24Fgp2vrKGf2kebp4b3LBSiU/MLAWsYLp5zIeScwbGm6krOqoyqA pJeC9gs6BA4hnoomq7x1Zrw1Rf2tTKlm9Ub+8zQ6ck4+uYmFx83ccjiKiBpxCJG9T9 mpMHw1z55iBZwBiiNSU4DR200QwxuVHUKn6xUslo= Date: Fri, 16 Aug 2019 22:13:18 -0700 From: Eric Biggers To: Hans de Goede Cc: Herbert Xu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Ard Biesheuvel , linux-crypto@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] crypto: sha256_generic - Use sha256_transform from generic sha256 lib Message-ID: <20190817051318.GA8209@sol.localdomain> Mail-Followup-To: Hans de Goede , Herbert Xu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Ard Biesheuvel , linux-crypto@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190816211611.2568-1-hdegoede@redhat.com> <20190816211611.2568-7-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190816211611.2568-7-hdegoede@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 16, 2019 at 11:16:11PM +0200, Hans de Goede wrote: > Drop the duplicate sha256_transform function from crypto/sha256_generic.c > and use the implementation from lib/crypto/sha256.c instead. > "diff -u lib/crypto/sha256.c sha256_generic.c" > shows that both implementations are identical. > > Signed-off-by: Hans de Goede Hi Hans, thanks for doing this! I'm a little concerned that the only sha256 lib function which sha256_generic.c calls is sha256_transform(). This means that sha256_init(), sha256_update(), and sha256_final() are not tested by the crypto self-tests. They could be broken and we wouldn't know. IMO, it would be better to make sha256_generic.c use sha256_init(), sha256_update(), and sha256_final() rather than using sha256_base.h. Then we'd get test coverage of both the sha256 lib, and of sha256_base.h via the architecture-specific implementations. To do this you'll also need to add sha224_init(), sha224_update(), and sha224_final(). But that's straightforward. - Eric