From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CAB2C3A59B for ; Sat, 17 Aug 2019 05:19:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2865621744 for ; Sat, 17 Aug 2019 05:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566019186; bh=0m42WxpnNvB2LIIoXV3Qt7RozsFwLPhdGtSDshLxu/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=etPdLxBLCJJCFkxfCQzuVPnq2S48k47bexKkMecObqZP9XU3quAmwuGi04MhaPCJ+ 7CYCZ5M8WGnGvWX56fUXj98vDFJ5Tr477gEe4h2dJG8+myuu/Mmw8YSMqafpF7lBOR NvQQcxSe4sW3i8hJogE67KlyoO+oVgftZ+9pjqh0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725784AbfHQFTp (ORCPT ); Sat, 17 Aug 2019 01:19:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:56744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725562AbfHQFTp (ORCPT ); Sat, 17 Aug 2019 01:19:45 -0400 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4E2C2133F; Sat, 17 Aug 2019 05:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566019184; bh=0m42WxpnNvB2LIIoXV3Qt7RozsFwLPhdGtSDshLxu/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZYwco9Y0vgtdu7K3kODtpMJ4HtpuvNU7e8UGNub397SYEx5RU2n86BfXBlwstep8K xaSCL7XzkJuT1rxzuVUBL12jh3zpsEd+MLtMSJmzClS3NKy9loo1CgfmnpTeRwpM8e s9g+iAQu8jHnQOIpMYYmnn4sdcLHW/ZzulmZPjAI= Date: Fri, 16 Aug 2019 22:19:42 -0700 From: Eric Biggers To: Hans de Goede Cc: Herbert Xu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Ard Biesheuvel , linux-crypto@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] crypto: sha256 - Move lib/sha256.c to lib/crypto Message-ID: <20190817051942.GB8209@sol.localdomain> Mail-Followup-To: Hans de Goede , Herbert Xu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Ard Biesheuvel , linux-crypto@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190816211611.2568-1-hdegoede@redhat.com> <20190816211611.2568-4-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190816211611.2568-4-hdegoede@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 16, 2019 at 11:16:08PM +0200, Hans de Goede wrote: > diff --git a/include/linux/sha256.h b/include/crypto/sha256.h > similarity index 100% > rename from include/linux/sha256.h > rename to include/crypto/sha256.h already has the declarations for both SHA-1 and SHA-2, including SHA-256. So I'm not sure a separate sha256.h is appropriate. How about putting these declarations in ? - Eric