From: Arnd Bergmann <arnd@arndb.de>
To: Zhou Wang <wangzhou1@hisilicon.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Hao Fang <fanghao11@huawei.com>,
Kenneth Lee <liguozhu@hisilicon.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] crypto: hisilicon - avoid unused function warning
Date: Fri, 6 Sep 2019 17:22:30 +0200 [thread overview]
Message-ID: <20190906152250.1450649-2-arnd@arndb.de> (raw)
In-Reply-To: <20190906152250.1450649-1-arnd@arndb.de>
The only caller of hisi_zip_vf_q_assign() is hidden in an #ifdef,
so the function causes a warning when CONFIG_PCI_IOV is disabled:
drivers/crypto/hisilicon/zip/zip_main.c:740:12: error: unused function 'hisi_zip_vf_q_assign' [-Werror,-Wunused-function]
Move it into the same #ifdef.
Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/crypto/hisilicon/zip/zip_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c
index 6e0ca75585d4..bd0283c2fa87 100644
--- a/drivers/crypto/hisilicon/zip/zip_main.c
+++ b/drivers/crypto/hisilicon/zip/zip_main.c
@@ -736,6 +736,7 @@ static int hisi_zip_probe(struct pci_dev *pdev, const struct pci_device_id *id)
return ret;
}
+#ifdef CONFIG_PCI_IOV
/* Currently we only support equal assignment */
static int hisi_zip_vf_q_assign(struct hisi_zip *hisi_zip, int num_vfs)
{
@@ -764,6 +765,7 @@ static int hisi_zip_vf_q_assign(struct hisi_zip *hisi_zip, int num_vfs)
return 0;
}
+#endif
static int hisi_zip_clear_vft_config(struct hisi_zip *hisi_zip)
{
--
2.20.0
next prev parent reply other threads:[~2019-09-06 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 15:22 [PATCH 1/2] crypto: inside-secure - fix uninitialized-variable warning Arnd Bergmann
2019-09-06 15:22 ` Arnd Bergmann [this message]
2019-09-13 9:17 ` [PATCH 2/2] crypto: hisilicon - avoid unused function warning Herbert Xu
2019-09-19 8:11 ` Zhou Wang
2019-09-19 13:48 ` Herbert Xu
2019-09-19 14:07 ` Arnd Bergmann
2019-09-06 16:08 ` [PATCH 1/2] crypto: inside-secure - fix uninitialized-variable warning Pascal Van Leeuwen
2019-09-06 18:39 ` Arnd Bergmann
2019-09-06 20:18 ` Pascal Van Leeuwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906152250.1450649-2-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=davem@davemloft.net \
--cc=fanghao11@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=liguozhu@hisilicon.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox