From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Laurent Vivier <lvivier@redhat.com>
Cc: linux-kernel@vger.kernel.org, Amit Shah <amit@kernel.org>,
linux-crypto@vger.kernel.org, Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] hw_random: don't wait on add_early_randomness()
Date: Tue, 17 Sep 2019 11:36:20 -0400 [thread overview]
Message-ID: <20190917153620.GG6762@mit.edu> (raw)
In-Reply-To: <20190917095450.11625-1-lvivier@redhat.com>
On Tue, Sep 17, 2019 at 11:54:50AM +0200, Laurent Vivier wrote:
> add_early_randomness() is called by hwrng_register() when the
> hardware is added. If this hardware and its module are present
> at boot, and if there is no data available the boot hangs until
> data are available and can't be interrupted.
>
> To avoid that, call rng_get_data() in non-blocking mode (wait=0)
> from add_early_randomness().
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Looks good, you can add:
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2019-09-17 15:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 9:54 [PATCH] hw_random: don't wait on add_early_randomness() Laurent Vivier
2019-09-17 12:40 ` Herbert Xu
2019-09-17 13:02 ` Laurent Vivier
2019-09-20 13:03 ` Herbert Xu
2019-09-17 15:36 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917153620.GG6762@mit.edu \
--to=tytso@mit.edu \
--cc=amit@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).