From: Eric Biggers <ebiggers@kernel.org>
To: Jamie Heilman <jamie@audible.transient.net>
Cc: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] crypto: padlock-aes - convert to skcipher API
Date: Sun, 13 Oct 2019 21:54:38 -0700 [thread overview]
Message-ID: <20191014045438.GE10007@sol.localdomain> (raw)
In-Reply-To: <20191014044726.GB3266@audible.transient.net>
On Mon, Oct 14, 2019 at 04:47:27AM +0000, Jamie Heilman wrote:
> Eric Biggers wrote:
> > > I built a patched 5.3.6 with none of the crypto bits modularized
> > > and you can find that dmesg and config at:
> > >
> > > http://audible.transient.net/~jamie/k/skcipher.config-5.3.6
> > > http://audible.transient.net/~jamie/k/skcipher.dmesg
> > >
> >
> > Great, I don't see any test failures in the log. Just to double
> > check, you had applied both Ard's patch and this one, right?:
> >
> > crypto: geode-aes - switch to skcipher for cbc(aes) fallback
> > crypto: geode-aes - convert to skcipher API and make thread-safe
>
> Er, no? Just the VIA padlock-aes.c change from you on top of a stock
> 5.3.6 tree, nothing from Ard. No geode here.
>
Oops, sorry, I confused this with a different driver. Yes, if you just applied
this padlock-aes patch it's good.
Thanks for testing!
- Eric
next prev parent reply other threads:[~2019-10-14 4:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 4:17 [PATCH] crypto: padlock-aes - convert to skcipher API Eric Biggers
2019-10-13 23:20 ` Jamie Heilman
2019-10-14 3:12 ` Eric Biggers
2019-10-14 4:47 ` Jamie Heilman
2019-10-14 4:54 ` Eric Biggers [this message]
2019-10-14 12:33 ` Ard Biesheuvel
2019-10-18 8:05 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014045438.GE10007@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jamie@audible.transient.net \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox