* [PATCH] crypto: arm64/ghash-neon - bump priority to 150
@ 2019-11-28 12:55 Ard Biesheuvel
2019-12-11 9:40 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Ard Biesheuvel @ 2019-11-28 12:55 UTC (permalink / raw)
To: linux-crypto; +Cc: herbert, Ard Biesheuvel
The SIMD based GHASH implementation for arm64 is typically much faster
than the generic one, and doesn't use any lookup tables, so it is
clearly preferred when available. So bump the priority to reflect that.
Fixes: 5a22b198cd527447 ("crypto: arm64/ghash - register PMULL variants ...")
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
arch/arm64/crypto/ghash-ce-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/crypto/ghash-ce-glue.c b/arch/arm64/crypto/ghash-ce-glue.c
index 522cf004ce65..196aedd0c20c 100644
--- a/arch/arm64/crypto/ghash-ce-glue.c
+++ b/arch/arm64/crypto/ghash-ce-glue.c
@@ -259,7 +259,7 @@ static int ghash_setkey(struct crypto_shash *tfm,
static struct shash_alg ghash_alg[] = {{
.base.cra_name = "ghash",
.base.cra_driver_name = "ghash-neon",
- .base.cra_priority = 100,
+ .base.cra_priority = 150,
.base.cra_blocksize = GHASH_BLOCK_SIZE,
.base.cra_ctxsize = sizeof(struct ghash_key),
.base.cra_module = THIS_MODULE,
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: arm64/ghash-neon - bump priority to 150
2019-11-28 12:55 [PATCH] crypto: arm64/ghash-neon - bump priority to 150 Ard Biesheuvel
@ 2019-12-11 9:40 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2019-12-11 9:40 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: linux-crypto
On Thu, Nov 28, 2019 at 01:55:31PM +0100, Ard Biesheuvel wrote:
> The SIMD based GHASH implementation for arm64 is typically much faster
> than the generic one, and doesn't use any lookup tables, so it is
> clearly preferred when available. So bump the priority to reflect that.
>
> Fixes: 5a22b198cd527447 ("crypto: arm64/ghash - register PMULL variants ...")
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/arm64/crypto/ghash-ce-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-11 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-28 12:55 [PATCH] crypto: arm64/ghash-neon - bump priority to 150 Ard Biesheuvel
2019-12-11 9:40 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).