Re: [v3 PATCH] crypto: api - fix unexpectedly getting generic implementation

Herbert Xu
2019-12-05T04:24:01Z

On Wed, Dec 04, 2019 at 08:04:42PM -0800, Eric Biggers wrote:
>
> This logic doesn't make sense to me either. It's supposed to be looking for a
> "test larval", not a "request larval", right? But it seems that larval->mask is
> always 0 for "test larvals", so the flags check will never do anything...

No we only care about request larvals. Test larvals always have
a non-null adult set so they are irrelevant.

> Also, different "request larvals" can use different flags and masks. So I don't
> think it's possible to know whether 'q' can fulfill every outstanding request
> that 'alg' can without actually going through and looking at the requests. So
> that's another case where users can start incorrectly getting ENOENT.

That's a good point. Let me think about this a bit more.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt