Re: [v3 PATCH] crypto: api - fix unexpectedly getting generic implementation

Herbert Xu
2019-12-05T04:27:12Z

On Thu, Dec 05, 2019 at 12:23:57PM +0800, Herbert Xu wrote:
> On Wed, Dec 04, 2019 at 08:04:42PM -0800, Eric Biggers wrote:
> >
> > This logic doesn't make sense to me either. It's supposed to be looking for a
> > "test larval", not a "request larval", right? But it seems that larval->mask is
> > always 0 for "test larvals", so the flags check will never do anything...
>
> No we only care about request larvals. Test larvals always have
> a non-null adult set so they are irrelevant.

Scratch that. You're right we only care about test larvals and
if we wanted to check the flags we need to drill down to the
actual tested algorithm using larval->adult.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt