From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CFD1C43603 for ; Wed, 18 Dec 2019 02:49:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E42F218AC for ; Wed, 18 Dec 2019 02:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576637342; bh=1BKv8h/+dzKcUiIfipxIZWMQ8i8upDc4jXEX7+m0KVk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1GtfXQ7/WceDyL/4Pm+RPzm+KbJn4SrK8p06HDUEmFGjGaRaLtcMh6cKq2f+TltDf N83biyR4cDAz+COuWC1v7DAJ604LLJE2DOgar9liEJenLkqxFZ888ugDAllrLZzXgP dwwht0wIMy82RUbEnP0c9WhH6vaGsxuGL/e+eysw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbfLRCtB (ORCPT ); Tue, 17 Dec 2019 21:49:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:55922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbfLRCtB (ORCPT ); Tue, 17 Dec 2019 21:49:01 -0500 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C130321775; Wed, 18 Dec 2019 02:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576637340; bh=1BKv8h/+dzKcUiIfipxIZWMQ8i8upDc4jXEX7+m0KVk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EHDpXpALTn6/Be8Yse/ug/O91UvMPuhyuptwvlSsvUrrAIrzfNXPsgip3vSS4oeXp g22yLz0AGajElYC8RHCFGA6lnFaQ0O7b5jCAWRR6JSy5+MBB5x+pVf6AgtM8ExX9xc iTawQKfedGnY8lQeqpjO9w+ZFL+1KJhTTmkLZ3hM= Date: Tue, 17 Dec 2019 18:48:59 -0800 From: Eric Biggers To: "Jason A. Donenfeld" Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, Ard Biesheuvel Subject: Re: [PATCH crypto-next v6 0/3] crypto: poly1305 improvements Message-ID: <20191218024859.GB3636@sol.localdomain> References: <20191217174445.188216-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191217174445.188216-1-Jason@zx2c4.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Dec 17, 2019 at 06:44:42PM +0100, Jason A. Donenfeld wrote: > With no feedback on v5 beyond the need for a .gitignore in the second > commit of this v6, I think this series should now be good to go. Well, you've also sent 6 versions of this patchset in less than a week, so I'm not sure people have had enough time to review it. I've just left a few comments for things I noticed in a quick read-through. That being said, I don't think anyone plans to review the 4200 lines of assembly code anyway (which even the other OpenSSL developers don't understand [1]), so maybe it doesn't matter. [1] https://github.com/openssl/openssl/pull/2056#pullrequestreview-12242604 - Eric