From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Subject: [PATCH v2 0/6] crypto: remove old way of allocating and freeing instances
Date: Thu, 2 Jan 2020 20:04:34 -0800 [thread overview]
Message-ID: <20200103040440.12375-1-ebiggers@kernel.org> (raw)
This series makes all crypto templates use the new way of freeing
instances where a ->free() method is installed to the instance struct
itself. This replaces the weakly-typed method crypto_template::free().
skcipher and akcipher were already using the new way, while aead was
mostly but not always using the new way. shash and ahash were using the
old way. This series eliminates this inconsistency (and the redundant
code associated with it) by making everyone use the new way.
The last patch adds registration-time checks which verify that all
instances really have a ->free() method.
This series is an internal cleanup only; there are no changes for users
of the crypto API.
This series is based on top of my other series
"[PATCH v2 00/28] crypto: template instantiation cleanup".
Changed v1 => v2:
- Rebased onto v2 of the other series.
Eric Biggers (6):
crypto: hash - add support for new way of freeing instances
crypto: geniv - convert to new way of freeing instances
crypto: cryptd - convert to new way of freeing instances
crypto: shash - convert shash_free_instance() to new style
crypto: algapi - remove crypto_template::{alloc,free}()
crypto: algapi - enforce that all instances have a ->free() method
crypto/aead.c | 8 +++----
crypto/ahash.c | 11 +++++++++
crypto/akcipher.c | 2 ++
crypto/algapi.c | 5 ----
crypto/algboss.c | 12 +---------
crypto/ccm.c | 5 ++--
crypto/cmac.c | 5 ++--
crypto/cryptd.c | 42 ++++++++++++++++-----------------
crypto/echainiv.c | 20 ++++------------
crypto/geniv.c | 15 ++++++------
crypto/hmac.c | 5 ++--
crypto/seqiv.c | 20 ++++------------
crypto/shash.c | 19 +++++++++++----
crypto/skcipher.c | 3 +++
crypto/vmac.c | 5 ++--
crypto/xcbc.c | 5 ++--
include/crypto/algapi.h | 2 --
include/crypto/internal/geniv.h | 1 -
include/crypto/internal/hash.h | 4 +++-
19 files changed, 89 insertions(+), 100 deletions(-)
--
2.24.1
next reply other threads:[~2020-01-03 4:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 4:04 Eric Biggers [this message]
2020-01-03 4:04 ` [PATCH v2 1/6] crypto: hash - add support for new way of freeing instances Eric Biggers
2020-01-03 4:04 ` [PATCH v2 2/6] crypto: geniv - convert to " Eric Biggers
2020-01-03 4:04 ` [PATCH v2 3/6] crypto: cryptd " Eric Biggers
2020-01-03 4:04 ` [PATCH v2 4/6] crypto: shash - convert shash_free_instance() to new style Eric Biggers
2020-01-03 4:04 ` [PATCH v2 5/6] crypto: algapi - remove crypto_template::{alloc,free}() Eric Biggers
2020-01-03 4:04 ` [PATCH v2 6/6] crypto: algapi - enforce that all instances have a ->free() method Eric Biggers
2020-01-09 5:15 ` [PATCH v2 0/6] crypto: remove old way of allocating and freeing instances Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103040440.12375-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).