From: Eric Biggers <ebiggers@kernel.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: lib/sha256 - return void
Date: Fri, 1 May 2020 09:39:19 -0700 [thread overview]
Message-ID: <20200501163919.GA915@sol.localdomain> (raw)
In-Reply-To: <3ba66f39-e84f-43c6-a36b-17cd231f55db@c-s.fr>
On Fri, May 01, 2020 at 02:28:12PM +0200, Christophe Leroy wrote:
> > -extern int sha256_update(struct sha256_state *sctx, const u8 *input,
> > - unsigned int length);
> > -extern int sha256_final(struct sha256_state *sctx, u8 *hash);
> > +extern void sha256_update(struct sha256_state *sctx, const u8 *data,
> > + unsigned int len);
> > +extern void sha256_final(struct sha256_state *sctx, u8 *out);
>
> The 'extern' keywork is useless in a function declaration. It should be
> removed, as recommended by 'checkpatch --strict'.
Sure I can do this, just keep in mind that a lot of kernel code still uses
'extern' (including the other function declarations in this file) and some
people still disagree about the preferred style. That's why this warning hasn't
been enabled in 'checkpatch' by default.
- Eric
prev parent reply other threads:[~2020-05-01 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 7:13 [PATCH] crypto: lib/sha256 - return void Eric Biggers
2020-05-01 12:28 ` Christophe Leroy
2020-05-01 16:39 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501163919.GA915@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).