From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] crypto: lib/sha256 - return void
Date: Fri, 1 May 2020 15:40:30 -0600 [thread overview]
Message-ID: <20200501214030.GA522402@zx2c4.com> (raw)
In-Reply-To: <20200501164229.24952-1-ebiggers@kernel.org>
On Fri, May 01, 2020 at 09:42:29AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The SHA-256 / SHA-224 library functions can't fail, so remove the
> useless return value.
Looks good to me, and also matches the signatures of the blake2s library
functions, which return null.
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
next prev parent reply other threads:[~2020-05-01 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 16:42 [PATCH v2] crypto: lib/sha256 - return void Eric Biggers
2020-05-01 21:40 ` Jason A. Donenfeld [this message]
2020-05-08 6:06 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501214030.GA522402@zx2c4.com \
--to=jason@zx2c4.com \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).