From: Eric Biggers <ebiggers@kernel.org>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] crypto: CRYPTO_CTR no longer need CRYPTO_SEQIV
Date: Thu, 4 Jun 2020 09:15:02 -0700 [thread overview]
Message-ID: <20200604161502.GA147774@gmail.com> (raw)
In-Reply-To: <1587735647-17718-3-git-send-email-clabbe@baylibre.com>
On Fri, Apr 24, 2020 at 01:40:46PM +0000, Corentin Labbe wrote:
> As comment of the v2, Herbert said: "The SEQIV select from CTR is historical
> and no longer necessary."
>
> So let's get rid of it.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> crypto/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 6d27fc6a7bf5..a5936e967fe2 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -370,7 +370,6 @@ config CRYPTO_CFB
> config CRYPTO_CTR
> tristate "CTR support"
> select CRYPTO_SKCIPHER
> - select CRYPTO_SEQIV
> select CRYPTO_MANAGER
> help
> CTR: Counter mode
Shouldn't this patch also have added 'select CRYPTO_SEQIV' to INET_ESP and
INET6_ESP? Or is the intent to make people explicitly select CRYPTO_SEQIV?
- Eric
next prev parent reply other threads:[~2020-06-04 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 13:40 [PATCH v3 0/3] crypto: fix some DRBG Kconfig deps Corentin Labbe
2020-04-24 13:40 ` [PATCH v3 1/3] crypto: drbg: DRBG should select SHA512 Corentin Labbe
2020-04-30 4:43 ` Herbert Xu
2020-04-24 13:40 ` [PATCH v3 2/3] crypto: CRYPTO_CTR no longer need CRYPTO_SEQIV Corentin Labbe
2020-06-04 16:15 ` Eric Biggers [this message]
2020-04-24 13:40 ` [PATCH v3 3/3] crypto: drbg: DRBG_CTR should select CTR Corentin Labbe
2020-04-30 5:32 ` [PATCH v3 0/3] crypto: fix some DRBG Kconfig deps Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604161502.GA147774@gmail.com \
--to=ebiggers@kernel.org \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).