From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [v2 PATCH] crc-t10dif: Fix potential crypto notify dead-lock
Date: Fri, 5 Jun 2020 11:48:46 -0700 [thread overview]
Message-ID: <20200605184846.GI1373@sol.localdomain> (raw)
In-Reply-To: <20200605182522.GA9536@gondor.apana.org.au>
On Sat, Jun 06, 2020 at 04:25:22AM +1000, Herbert Xu wrote:
> > That would make the checks for a NULL tfm in crc_t10dif_transform_show() and
> > crc_t10dif_notify() unnecessary. Also, it would make it so that
> > crc_t10dif_update() no longer crashes if called before module_init().
>
> crc_t10dif_update can never be called prior to module_init while
> the other two functions both can.
>
That's only guaranteed to be true if the code is built is a loadable module. If
it's built-in to the kernel, it could be called earlier, by a previous initcall.
Probably no one is running into this now, but it could happen in the future.
- Eric
next prev parent reply other threads:[~2020-06-05 18:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 6:33 [PATCH] crc-t10dif: Fix potential crypto notify dead-lock Herbert Xu
2020-06-05 5:40 ` Eric Biggers
2020-06-05 6:49 ` Herbert Xu
2020-06-05 6:59 ` [v2 PATCH] " Herbert Xu
2020-06-05 18:22 ` Eric Biggers
2020-06-05 18:25 ` Herbert Xu
2020-06-05 18:48 ` Eric Biggers [this message]
2020-06-08 6:25 ` Herbert Xu
2020-06-05 18:45 ` Eric Biggers
2020-06-08 6:26 ` Herbert Xu
2020-06-09 1:28 ` Martin K. Petersen
2020-06-10 6:42 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605184846.GI1373@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox