From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A07D0C433E0 for ; Wed, 10 Jun 2020 01:01:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83633206C3 for ; Wed, 10 Jun 2020 01:01:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726081AbgFJBBE (ORCPT ); Tue, 9 Jun 2020 21:01:04 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:59166 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726030AbgFJBBE (ORCPT ); Tue, 9 Jun 2020 21:01:04 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jip6z-0007gj-93; Wed, 10 Jun 2020 11:01:02 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Wed, 10 Jun 2020 11:01:01 +1000 Date: Wed, 10 Jun 2020 11:01:01 +1000 From: Herbert Xu To: Eric Biggers Cc: netdev@vger.kernel.org, linux-crypto@vger.kernel.org, Corentin Labbe , Greg Kroah-Hartman , Steffen Klassert Subject: Re: [PATCH net v3 2/3] esp: select CRYPTO_SEQIV Message-ID: <20200610010101.GB6380@gondor.apana.org.au> References: <20200610005402.152495-1-ebiggers@kernel.org> <20200610005402.152495-3-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200610005402.152495-3-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jun 09, 2020 at 05:54:01PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Commit f23efcbcc523 ("crypto: ctr - no longer needs CRYPTO_SEQIV") made > CRYPTO_CTR stop selecting CRYPTO_SEQIV. This breaks IPsec for most > users since GCM and several other encryption algorithms require "seqiv" > -- and RFC 8221 lists AES-GCM as "MUST" be implemented. > > Just make XFRM_ESP select CRYPTO_SEQIV. > > Fixes: f23efcbcc523 ("crypto: ctr - no longer needs CRYPTO_SEQIV") made > Cc: Corentin Labbe > Cc: Greg Kroah-Hartman > Cc: Herbert Xu > Cc: Steffen Klassert > Signed-off-by: Eric Biggers > --- > net/xfrm/Kconfig | 1 + > 1 file changed, 1 insertion(+) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt