From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: netdev@vger.kernel.org, linux-crypto@vger.kernel.org,
Corentin Labbe <clabbe@baylibre.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH net v3 3/3] esp, ah: modernize the crypto algorithm selections
Date: Wed, 10 Jun 2020 11:01:10 +1000 [thread overview]
Message-ID: <20200610010110.GC6380@gondor.apana.org.au> (raw)
In-Reply-To: <20200610005402.152495-4-ebiggers@kernel.org>
On Tue, Jun 09, 2020 at 05:54:02PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The crypto algorithms selected by the ESP and AH kconfig options are
> out-of-date with the guidance of RFC 8221, which lists the legacy
> algorithms MD5 and DES as "MUST NOT" be implemented, and some more
> modern algorithms like AES-GCM and HMAC-SHA256 as "MUST" be implemented.
> But the options select the legacy algorithms, not the modern ones.
>
> Therefore, modify these options to select the MUST algorithms --
> and *only* the MUST algorithms.
>
> Also improve the help text.
>
> Suggested-by: Herbert Xu <herbert@gondor.apana.org.au>
> Suggested-by: Steffen Klassert <steffen.klassert@secunet.com>
> Cc: Corentin Labbe <clabbe@baylibre.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> net/ipv4/Kconfig | 21 +++++++++++++++++++--
> net/ipv6/Kconfig | 21 +++++++++++++++++++--
> net/xfrm/Kconfig | 15 +++++++++------
> 3 files changed, 47 insertions(+), 10 deletions(-)
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-06-10 1:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 0:53 [PATCH net v3 0/3] esp, ah: improve crypto algorithm selections Eric Biggers
2020-06-10 0:54 ` [PATCH net v3 1/3] esp, ah: consolidate the " Eric Biggers
2020-06-10 1:00 ` Herbert Xu
2020-06-10 0:54 ` [PATCH net v3 2/3] esp: select CRYPTO_SEQIV Eric Biggers
2020-06-10 1:01 ` Herbert Xu
2020-06-10 0:54 ` [PATCH net v3 3/3] esp, ah: modernize the crypto algorithm selections Eric Biggers
2020-06-10 1:01 ` Herbert Xu [this message]
2020-06-10 9:03 ` Tobias Brunner
2020-06-10 15:53 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610010110.GC6380@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=clabbe@baylibre.com \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox