From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D325AC433DF for ; Wed, 10 Jun 2020 06:56:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89367207ED for ; Wed, 10 Jun 2020 06:56:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591772163; bh=5STvsVX/pI2NfrFCiamfYh+BDyGD5ZoTDgeDDX/5rC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=A0k1wtkRN3Tm1lgNhCGXULnPoqRW0oOzK5LuT2whb+6tEyLIipXhLpvVFXOK6nkB5 QkmQuqT6cju0FNKfjLH8qcDAZQX6IMHgpPeL576EodbxQwRMiyI6k6ocasqgN6VWVk dvdjjtfJQO0q8sHtFHLWJEt9PH3y4xfV7QuDLFYY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726153AbgFJG4C (ORCPT ); Wed, 10 Jun 2020 02:56:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:50094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbgFJG4C (ORCPT ); Wed, 10 Jun 2020 02:56:02 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA97720734; Wed, 10 Jun 2020 06:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591772162; bh=5STvsVX/pI2NfrFCiamfYh+BDyGD5ZoTDgeDDX/5rC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e0MwBkvVTHUTmDVaH2vs5miGgN/MlrVKlfR/M/NyC6z80FCNSovuYF3uG+UTFzncx K0Jw9d2Q+Xdzc857h54ARg/fkhIfNgHko4RrdSNNo2BoMbGGOEBC/hqiAdlZEYOjoK vbM66H6VJhracJhCR5+CRIKHf0mcX3BfwTGCSD+c= Date: Tue, 9 Jun 2020 23:56:00 -0700 From: Eric Biggers To: David Laight Cc: 'Herbert Xu' , Zhangfei Gao , Greg Kroah-Hartman , Jonathan Cameron , wangzhou1 , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "kbuild-all@lists.01.org" Subject: Re: [PATCH] crypto: hisilicon - fix strncpy warning with strlcpy Message-ID: <20200610065600.GC6286@sol.localdomain> References: <202006032110.BEbKqovX%lkp@intel.com> <1591241524-6452-1-git-send-email-zhangfei.gao@linaro.org> <20200604033918.GA2286@gondor.apana.org.au> <20200604061811.GA28759@gondor.apana.org.au> <20200604065009.GA29822@gondor.apana.org.au> <20200605121703.GA3792@gondor.apana.org.au> <8c0d8f4e21794d8b80d0a3852830debb@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c0d8f4e21794d8b80d0a3852830debb@AcuMS.aculab.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Jun 07, 2020 at 01:03:45PM +0000, David Laight wrote: > From: Herbert Xu > > Sent: 05 June 2020 13:17 > ... > > Better yet use strscpy which will even return an error for you. > > It really ought to return the buffer length on truncation. > Then you can loop: > while(...) > buf += strxxxcpy(buf, src, buf_end - buf); > and only check right at the end. > > David scnprintf() can be used for that. But that doesn't seem relevant to this patch. - Eric