Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Su Kang Yin <cantona@cantona.net>,
	linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: talitos - fix ECB and CBC algs ivsize
Date: Thu, 11 Jun 2020 13:23:12 +0200	[thread overview]
Message-ID: <20200611112312.GB342390@kroah.com> (raw)
In-Reply-To: <24a06073-1765-985e-029b-80a78ad02b89@csgroup.eu>

On Thu, Jun 11, 2020 at 01:09:38PM +0200, Christophe Leroy wrote:
> 
> 
> Le 11/06/2020 à 13:03, Greg KH a écrit :
> > On Thu, Jun 11, 2020 at 12:50:24PM +0200, Christophe Leroy wrote:
> > > Hi,
> > > 
> > > Le 11/06/2020 à 12:07, Su Kang Yin a écrit :
> > > > Patch for 4.9 upstream:
> > > > 
> > > > commit e1de42fdfc6a ("crypto: talitos - fix ECB algs ivsize")
> > > > wrongly modified CBC algs ivsize instead of ECB aggs ivsize.
> > > 
> > > To make it clear and avoid this problem to happen again, please generate
> > > your patch with option -U8
> > 
> > No need, this patch should be fine as-is.
> > 
> 
> Still, this patch includes more than the original patch as far as I can see
> (scroll down and see other comments in that answer)

Ah, good catch, I'll go drop this now, thanks!

greg k-h

  reply	other threads:[~2020-06-11 11:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 10:07 [PATCH] crypto: talitos - fix ECB and CBC algs ivsize Su Kang Yin
2020-06-11 10:50 ` Christophe Leroy
2020-06-11 11:03   ` Greg KH
2020-06-11 11:09     ` Christophe Leroy
2020-06-11 11:23       ` Greg KH [this message]
2020-06-11 10:54 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200611112312.GB342390@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=cantona@cantona.net \
    --cc=christophe.leroy@csgroup.eu \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox