From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB633C43464 for ; Fri, 18 Sep 2020 08:07:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B406C2176B for ; Fri, 18 Sep 2020 08:07:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="waJaW8Mt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726515AbgIRIHD (ORCPT ); Fri, 18 Sep 2020 04:07:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbgIRIHC (ORCPT ); Fri, 18 Sep 2020 04:07:02 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96FC4C061756 for ; Fri, 18 Sep 2020 01:07:02 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id x23so4393205wmi.3 for ; Fri, 18 Sep 2020 01:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tgDf+8aovxjwoFqw2pAtXyIqTcZuyQ4tZIemMpo6x5g=; b=waJaW8Mte9D9mu7wVneZdTaseFBahkj505vErBuQBlQdpJCv75cCAvwDEWNFUdX0yw vYzf5M/L1eh5a+L0kuixVIG7B/rrBkqi9HSe10xnQGCX0q2eVFVVU0cLlhyGWAdNMc7L dXQBDU/znPYpMoRmNtBz8CktfjhKqXMdmgeqAfrLx9i7wlrwgkd31B5QiSOjjLSBwkzV zilkLklpmyL1MOZuZ3hw6WhcgZy0qw5zi/nT35DeJM0MCuoa0y+0ztiQHZxanmwOVTJn g/EpZ23RO+2tZsx9k9JwZ/FAn9YMTUN5othT0vqOf8E1E+FnGLkaoOj6G3nkYHEg7THo vknw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tgDf+8aovxjwoFqw2pAtXyIqTcZuyQ4tZIemMpo6x5g=; b=WU3G5rsySZQjZUoGNQgbEPeMVPIIwkBSUcWeDYqJ75J3Eyb2qT8ZloHPVEquA5cjN9 yL6RQkZbt8GA2c9jc4S7mOT3eWMb1Am0DssQf2Iy3ZES+5OWSuM8z3pTVFkgz03W7IIc PacMrV8ny6TF+Rmk7RRf9utf6GkVyTGOUJIElr/Uz9V13091dxGi+2OzGPpnvhMgTa8C gl4r3nxLfK0iwhMoBgWgWvrFrgD6jFu8w3B9aOyX5ny/HC+NhBWT8g4h3qATQPg7ezcW J6aRELiPN1MDKErDudqTB4yHiGEGI4njwhnOO2BE0QVk540IKqOBNIVifSmnXbG1TZbC gFaA== X-Gm-Message-State: AOAM5323ucwNWUACs5VqNNpOIbnO6fr66vJMYP0mCYuPMIB0JLr8FIds jan73NV4qGLVowDsjSZucxvtqYM4l35Ayw== X-Google-Smtp-Source: ABdhPJzLuGCkjX50uDxEUgN+LexVakjf3B5xC2tQu09Z2pdTpH6+Pd24cnvL3XO8Yfc9PLw9FvZOnw== X-Received: by 2002:a7b:c4d9:: with SMTP id g25mr14060379wmk.15.1600416421193; Fri, 18 Sep 2020 01:07:01 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id r15sm3524860wmn.24.2020.09.18.01.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 01:07:00 -0700 (PDT) Date: Fri, 18 Sep 2020 10:06:58 +0200 From: LABBE Corentin To: Herbert Xu Cc: arnd@arndb.de, davem@davemloft.net, mripard@kernel.org, wens@csie.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, stable@vger.kernel.org Subject: Re: [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher Message-ID: <20200918080658.GA22656@Red> References: <1600367758-28589-1-git-send-email-clabbe@baylibre.com> <1600367758-28589-5-git-send-email-clabbe@baylibre.com> <20200918073128.GA24168@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200918073128.GA24168@gondor.apana.org.au> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Sep 18, 2020 at 05:31:28PM +1000, Herbert Xu wrote: > On Thu, Sep 17, 2020 at 06:35:55PM +0000, Corentin Labbe wrote: > > Ciphers produce invalid results on BE. > > Key and IV need to be written in LE. > > Furthermore, the non-optimized function is too complicated to convert, > > let's simply fallback on BE for the moment. > > > > Fixes: 6298e948215f2 ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator") > > Cc: > > Signed-off-by: Corentin Labbe > > --- > > .../crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 17 +++++++++++------ > > 1 file changed, 11 insertions(+), 6 deletions(-) > > Does the BE failure get caught by the selftest? > Yes, selftest found it. > If so please just leave it enabled so that it can be fixed properly. Not sure to leave it enabled is a good idea. A least, leaving it failing probably will not annoy any user (according to my readings of #linux-sunxi, nobody use BE). But I think only me will see it and since I already have this on my TODO list, I dont see any interest to leave it failing. Furthermore, having a clean BE boot will permit to enable BE boots for thoses SoCs on kernelCI. Regards