From: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
To: Liu Shixin <liushixin2@huawei.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
qat-linux <qat-linux@intel.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] crypto: qat - convert to use DEFINE_SEQ_ATTRIBUTE macro
Date: Thu, 24 Sep 2020 06:00:42 +0100 [thread overview]
Message-ID: <20200924050042.GA32206@silpixa00400314> (raw)
In-Reply-To: <7a1e8142cb4944ee95cea13e7efad23d@irsmsx602.ger.corp.intel.com>
On Wed, Sep 16, 2020 at 03:50:17AM +0100, Liu Shixin wrote:
> Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
> drivers/crypto/qat/qat_common/adf_cfg.c | 19 +--------
> .../qat/qat_common/adf_transport_debug.c | 42 ++-----------------
> 2 files changed, 5 insertions(+), 56 deletions(-)
>
> diff --git a/drivers/crypto/qat/qat_common/adf_cfg.c b/drivers/crypto/qat/qat_common/adf_cfg.c
> index ac462796cefc..22ae32838113 100644
> --- a/drivers/crypto/qat/qat_common/adf_cfg.c
> +++ b/drivers/crypto/qat/qat_common/adf_cfg.c
> @@ -52,24 +52,7 @@ static const struct seq_operations qat_dev_cfg_sops = {
> .show = qat_dev_cfg_show
> };
>
> -static int qat_dev_cfg_open(struct inode *inode, struct file *file)
> -{
> - int ret = seq_open(file, &qat_dev_cfg_sops);
> -
> - if (!ret) {
> - struct seq_file *seq_f = file->private_data;
> -
> - seq_f->private = inode->i_private;
> - }
> - return ret;
> -}
> -
> -static const struct file_operations qat_dev_cfg_fops = {
> - .open = qat_dev_cfg_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = seq_release
> -};
> +DEFINE_SEQ_ATTRIBUTE(qat_dev_cfg);
>
> /**
> * adf_cfg_dev_add() - Create an acceleration device configuration table.
> diff --git a/drivers/crypto/qat/qat_common/adf_transport_debug.c b/drivers/crypto/qat/qat_common/adf_transport_debug.c
> index 2a2eccbf56ec..dac25ba47260 100644
> --- a/drivers/crypto/qat/qat_common/adf_transport_debug.c
> +++ b/drivers/crypto/qat/qat_common/adf_transport_debug.c
> @@ -77,31 +77,14 @@ static void adf_ring_stop(struct seq_file *sfile, void *v)
> mutex_unlock(&ring_read_lock);
> }
>
> -static const struct seq_operations adf_ring_sops = {
> +static const struct seq_operations adf_ring_debug_sops = {
> .start = adf_ring_start,
> .next = adf_ring_next,
> .stop = adf_ring_stop,
> .show = adf_ring_show
> };
>
> -static int adf_ring_open(struct inode *inode, struct file *file)
> -{
> - int ret = seq_open(file, &adf_ring_sops);
> -
> - if (!ret) {
> - struct seq_file *seq_f = file->private_data;
> -
> - seq_f->private = inode->i_private;
> - }
> - return ret;
> -}
> -
> -static const struct file_operations adf_ring_debug_fops = {
> - .open = adf_ring_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = seq_release
> -};
> +DEFINE_SEQ_ATTRIBUTE(adf_ring_debug);
>
> int adf_ring_debugfs_add(struct adf_etr_ring_data *ring, const char *name)
> {
> @@ -188,31 +171,14 @@ static void adf_bank_stop(struct seq_file *sfile, void *v)
> mutex_unlock(&bank_read_lock);
> }
>
> -static const struct seq_operations adf_bank_sops = {
> +static const struct seq_operations adf_bank_debug_sops = {
> .start = adf_bank_start,
> .next = adf_bank_next,
> .stop = adf_bank_stop,
> .show = adf_bank_show
> };
>
> -static int adf_bank_open(struct inode *inode, struct file *file)
> -{
> - int ret = seq_open(file, &adf_bank_sops);
> -
> - if (!ret) {
> - struct seq_file *seq_f = file->private_data;
> -
> - seq_f->private = inode->i_private;
> - }
> - return ret;
> -}
> -
> -static const struct file_operations adf_bank_debug_fops = {
> - .open = adf_bank_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = seq_release
> -};
> +DEFINE_SEQ_ATTRIBUTE(adf_bank_debug);
>
> int adf_bank_debugfs_add(struct adf_etr_bank_data *bank)
> {
> --
> 2.25.1
>
next parent reply other threads:[~2020-09-24 5:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7a1e8142cb4944ee95cea13e7efad23d@irsmsx602.ger.corp.intel.com>
2020-09-24 5:00 ` Giovanni Cabiddu [this message]
2020-09-25 8:14 ` [PATCH -next] crypto: qat - convert to use DEFINE_SEQ_ATTRIBUTE macro Herbert Xu
2020-09-25 8:49 ` Giovanni Cabiddu
2020-09-16 2:50 Liu Shixin
2020-09-25 8:11 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924050042.GA32206@silpixa00400314 \
--to=giovanni.cabiddu@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liushixin2@huawei.com \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox