Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Stephan M??ller <smueller@chronox.de>,
	Palmer Dabbelt <palmerdabbelt@google.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Android Kernel Team <kernel-team@android.com>,
	kernel test robot <lkp@intel.com>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: jitterentropy - bind statically into kernel
Date: Mon, 5 Oct 2020 07:19:18 +0100	[thread overview]
Message-ID: <20201005061918.GB1856@infradead.org> (raw)
In-Reply-To: <CAMj1kXEnOh4MBiVVgkhd4P81eRPCVi3+y6JcD58jL45-eh324A@mail.gmail.com>

On Sun, Oct 04, 2020 at 11:16:10PM +0200, Ard Biesheuvel wrote:
> On Sun, 4 Oct 2020 at 20:48, Stephan M??ller <smueller@chronox.de> wrote:
> >
> > The RISC-V architecture is about to implement the callback
> > random_get_entropy with a function that is not exported to modules.
> 
> Why is that? Wouldn't it be better to export the symbol instead?

get_cycles is a low-level time keeping detail that really should not
be exported, and at least for RISC-V this would be the only modular
user.  Once that is sorted out I'll audit other common architectures
to drop the export, as it isn't something that should be used in ramdom
driver code.

  parent reply	other threads:[~2020-10-05  6:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200930065617.934638-1-palmerdabbelt@google.com>
2020-10-02  6:49 ` get_cycles from modular code in jitterentropy, was Re: [PATCH] clocksource: clint: Export clint_time_val for modules Christoph Hellwig
2020-10-02  6:55   ` Stephan Mueller
2020-10-04 18:48   ` [PATCH] crypto: jitterentropy - bind statically into kernel Stephan Müller
2020-10-04 21:16     ` Ard Biesheuvel
2020-10-04 22:05       ` Palmer Dabbelt
2020-10-05  6:19       ` Christoph Hellwig [this message]
2020-10-05  6:24         ` Ard Biesheuvel
2020-10-05  6:40           ` Stephan Mueller
2020-10-05  6:44             ` Christoph Hellwig
2020-10-05  6:44             ` Ard Biesheuvel
2020-10-05  6:56               ` Christoph Hellwig
2020-10-05  7:45               ` Stephan Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201005061918.GB1856@infradead.org \
    --to=hch@infradead.org \
    --cc=ardb@kernel.org \
    --cc=kernel-team@android.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=palmerdabbelt@google.com \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox