From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8385C4363C for ; Wed, 7 Oct 2020 03:50:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F80820B1F for ; Wed, 7 Oct 2020 03:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602042624; bh=i3oNKL/37PPF5simVBecYvjtkUyfqCYU9nKNvTJQoAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2EX9HVrOxBrDOrMkXLH6lTEA2RXihmfdQD9sVbXiSwLxvTlD//Po5Wnzh/g/q1tma mDDQTKkjdQeJNvxoj1LbCVvHPCF2Zai3p6StZdc36dvdGJ94ydYXHnpb//EuTM24Cx H0ESX4J2DUVIvIAlAj0s5zQoEr+tqddI5VVFc8t4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726562AbgJGDuX (ORCPT ); Tue, 6 Oct 2020 23:50:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:45932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbgJGDuX (ORCPT ); Tue, 6 Oct 2020 23:50:23 -0400 Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4318B208C3; Wed, 7 Oct 2020 03:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602042623; bh=i3oNKL/37PPF5simVBecYvjtkUyfqCYU9nKNvTJQoAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iy5sYNRbdCkoUvm6wbjexcNUisor0wYEB5HIrkxoGtYbZRbJr7BEnqhK1J1EZg21I fIHaiv/M+IgV6PXLv3rJQqAKW9OTXxOmFDcPAYKwVHmEk4o6GRPlGgF0ANy9dzLOAq I50gl3OUVDLNw0PVxK2oPHelXeXLf4Ry6fRiKPvA= Date: Tue, 6 Oct 2020 20:50:21 -0700 From: Eric Biggers To: Theodore Ts'o Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Jann Horn Subject: Re: [PATCH] random: fix the RNDRESEEDCRNG ioctl Message-ID: <20201007035021.GB912@sol.localdomain> References: <20200916041908.66649-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916041908.66649-1-ebiggers@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Sep 15, 2020 at 09:19:08PM -0700, Eric Biggers wrote: > From: Eric Biggers > > The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which > doesn't make sense. Reseed it from the input_pool instead. > > Fixes: d848e5f8e1eb ("random: add new ioctl RNDRESEEDCRNG") > Cc: stable@vger.kernel.org > Signed-off-by: Eric Biggers Ping?