From: Nigel Christian <nigel.l.christian@gmail.com>
To: mpm@selenic.com, herbert@gondor.apana.org.au,
yuehaibing@huawei.com, hadar.gat@arm.com, martin@kaiser.cx,
arnd@arndb.de
Cc: linux-crypto@vger.kernel.org
Subject: [PATCH] hwrng: imx-rngc - platform_get_irq() already prints an error
Date: Sun, 18 Oct 2020 18:29:12 -0400 [thread overview]
Message-ID: <20201018222912.GA90387@fedora-thirty-three> (raw)
There is no need to call the dev_err() function directly to print
a custom message when handling an error from platform_get_irq()
as it prints the appropriate message in the event of a failure.
Change suggested via coccicheck report.
Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
---
drivers/char/hw_random/imx-rngc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index 61c844baf26e..69f13ff1bbec 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -253,7 +253,6 @@ static int imx_rngc_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq <= 0) {
- dev_err(&pdev->dev, "Couldn't get irq %d\n", irq);
return irq;
}
--
2.28.0
next reply other threads:[~2020-10-18 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 22:29 Nigel Christian [this message]
2020-10-22 20:16 ` [PATCH] hwrng: imx-rngc - platform_get_irq() already prints an error Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201018222912.GA90387@fedora-thirty-three \
--to=nigel.l.christian@gmail.com \
--cc=arnd@arndb.de \
--cc=hadar.gat@arm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=mpm@selenic.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox