From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0772AC55179 for ; Thu, 29 Oct 2020 09:14:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAD382076B for ; Thu, 29 Oct 2020 09:14:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726069AbgJ2JOy (ORCPT ); Thu, 29 Oct 2020 05:14:54 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:58736 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgJ2JOx (ORCPT ); Thu, 29 Oct 2020 05:14:53 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kY1kn-0000aA-0t; Thu, 29 Oct 2020 17:49:46 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 29 Oct 2020 17:49:45 +1100 Date: Thu, 29 Oct 2020 17:49:45 +1100 From: Herbert Xu To: Ard Biesheuvel Cc: Horia =?utf-8?Q?Geant=C4=83?= , "David S. Miller" , Russell King , Linux Crypto Mailing List , Linux ARM , NXP Linux Team , Linux Kernel Mailing List Subject: Re: [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback Message-ID: <20201029064944.GA19977@gondor.apana.org.au> References: <20201028090320.4222-1-horia.geanta@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Oct 28, 2020 at 10:06:58AM +0100, Ard Biesheuvel wrote: > > Not sure what is happening here: IIRC the intention was to rely on the > fact that only the sync cbc(aes) implementation needs the fallback, > and therefore, allocating a sync skcipher explicitly would avoid this > recursion. > > Herbert? It works only if everything is built in. If cbc is built as a module then you need Horia's patch to prevent a loop. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt