From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Srujana Challa <schalla@marvell.com>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-crypto@vger.kernel.org, sgoutham@marvell.com,
gakula@marvell.com, sbhatta@marvell.com, schandran@marvell.com,
pathreya@marvell.com, Lukasz Bartosik <lbartosik@marvell.com>
Subject: Re: [PATCH v9,net-next,12/12] crypto: octeontx2: register with linux crypto framework
Date: Fri, 13 Nov 2020 14:16:01 +1100 [thread overview]
Message-ID: <20201113031601.GA27112@gondor.apana.org.au> (raw)
In-Reply-To: <20201111161039.64830a68@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Wed, Nov 11, 2020 at 04:10:39PM -0800, Jakub Kicinski wrote:
> On Mon, 9 Nov 2020 17:39:24 +0530 Srujana Challa wrote:
> > CPT offload module utilises the linux crypto framework to offload
> > crypto processing. This patch registers supported algorithms by
> > calling registration functions provided by the kernel crypto API.
> >
> > The module currently supports:
> > - AES block cipher in CBC,ECB,XTS and CFB mode.
> > - 3DES block cipher in CBC and ECB mode.
> > - AEAD algorithms.
> > authenc(hmac(sha1),cbc(aes)),
> > authenc(hmac(sha256),cbc(aes)),
> > authenc(hmac(sha384),cbc(aes)),
> > authenc(hmac(sha512),cbc(aes)),
> > authenc(hmac(sha1),ecb(cipher_null)),
> > authenc(hmac(sha256),ecb(cipher_null)),
> > authenc(hmac(sha384),ecb(cipher_null)),
> > authenc(hmac(sha512),ecb(cipher_null)),
> > rfc4106(gcm(aes)).
>
> Herbert, could someone who knows about crypto take a look at this,
> if the intention is to merge this via net-next?
This patch seems to be quite large but it is self-contained. How
about waiting a release cycle and then resubmitting it to linux-crypto
on its own?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-11-13 3:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 12:09 [PATCH v9,net-next,00/12] Add Support for Marvell OcteonTX2 Cryptographic Acceleration Unit Srujana Challa
2020-11-09 12:09 ` [PATCH v9,net-next,01/12] octeontx2-pf: move lmt flush to include/linux/soc Srujana Challa
2020-11-09 12:09 ` [PATCH v9,net-next,02/12] octeontx2-af: add mailbox interface for CPT Srujana Challa
2020-11-09 12:09 ` [PATCH v9,net-next,03/12] octeontx2-af: add debugfs entries for CPT block Srujana Challa
2020-11-09 12:09 ` [PATCH v9,net-next,04/12] drivers: crypto: add Marvell OcteonTX2 CPT PF driver Srujana Challa
2020-11-09 12:09 ` [PATCH v9,net-next,05/12] crypto: octeontx2: add mailbox communication with AF Srujana Challa
2020-11-11 23:54 ` Jakub Kicinski
2020-11-12 7:07 ` [EXT] " Srujana Challa
2020-11-12 15:51 ` Jakub Kicinski
2020-11-09 12:09 ` [PATCH v9,net-next,06/12] crypto: octeontx2: enable SR-IOV and mailbox communication with VF Srujana Challa
2020-11-09 12:09 ` [PATCH v9,net-next,07/12] crypto: octeontx2: load microcode and create engine groups Srujana Challa
2020-11-09 12:09 ` [PATCH v9,net-next,08/12] crypto: octeontx2: add LF framework Srujana Challa
2020-11-09 12:09 ` [PATCH v9,net-next,09/12] crypto: octeontx2: add support to get engine capabilities Srujana Challa
2020-11-09 12:09 ` [PATCH v9,net-next,10/12] crypto: octeontx2: add virtual function driver support Srujana Challa
2020-11-09 12:09 ` [PATCH v9,net-next,11/12] crypto: octeontx2: add support to process the crypto request Srujana Challa
2020-11-09 12:09 ` [PATCH v9,net-next,12/12] crypto: octeontx2: register with linux crypto framework Srujana Challa
2020-11-12 0:10 ` Jakub Kicinski
2020-11-13 3:16 ` Herbert Xu [this message]
2020-11-13 16:44 ` Jakub Kicinski
2020-11-16 6:26 ` Herbert Xu
2020-11-17 7:59 ` Srujana Challa
2020-11-17 16:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113031601.GA27112@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=gakula@marvell.com \
--cc=kuba@kernel.org \
--cc=lbartosik@marvell.com \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pathreya@marvell.com \
--cc=sbhatta@marvell.com \
--cc=schalla@marvell.com \
--cc=schandran@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox