From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5737EC388F9 for ; Fri, 13 Nov 2020 05:09:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EADCC20A8B for ; Fri, 13 Nov 2020 05:09:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726134AbgKMFJy (ORCPT ); Fri, 13 Nov 2020 00:09:54 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:33668 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726023AbgKMFJy (ORCPT ); Fri, 13 Nov 2020 00:09:54 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kdRLJ-0000qR-PI; Fri, 13 Nov 2020 16:09:50 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 13 Nov 2020 16:09:49 +1100 Date: Fri, 13 Nov 2020 16:09:49 +1100 From: Herbert Xu To: "Jason A. Donenfeld" Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH crypto] crypto: Kconfig - CRYPTO_MANAGER_EXTRA_TESTS requires the manager Message-ID: <20201113050949.GA8350@gondor.apana.org.au> References: <20201102134815.512866-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102134815.512866-1-Jason@zx2c4.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Nov 02, 2020 at 02:48:15PM +0100, Jason A. Donenfeld wrote: > The extra tests in the manager actually require the manager to be > selected too. Otherwise the linker gives errors like: > > ld: arch/x86/crypto/chacha_glue.o: in function `chacha_simd_stream_xor': > chacha_glue.c:(.text+0x422): undefined reference to `crypto_simd_disabled_for_test' > > Fixes: 2343d1529aff ("crypto: Kconfig - allow tests to be disabled when manager is disabled") > Signed-off-by: Jason A. Donenfeld > --- > crypto/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt