From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6990DC5519F for ; Fri, 20 Nov 2020 06:57:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E2CF2223F for ; Fri, 20 Nov 2020 06:57:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726293AbgKTG5G (ORCPT ); Fri, 20 Nov 2020 01:57:06 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:34200 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbgKTG5G (ORCPT ); Fri, 20 Nov 2020 01:57:06 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kg0Lm-0007il-IE; Fri, 20 Nov 2020 17:56:55 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 20 Nov 2020 17:56:54 +1100 Date: Fri, 20 Nov 2020 17:56:54 +1100 From: Herbert Xu To: Horia =?utf-8?Q?Geant=C4=83?= Cc: Wang Qing , Aymen Sghaier , "David S. Miller" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: crypto: caam/qi - simplify error path for context allocation Message-ID: <20201120065654.GC20581@gondor.apana.org.au> References: <1604653287-16577-1-git-send-email-wangqing@vivo.com> <7e8409c9-ce91-3970-6ae0-e6e06987c117@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7e8409c9-ce91-3970-6ae0-e6e06987c117@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Nov 12, 2020 at 11:21:46AM +0200, Horia Geantă wrote: > > Wang Qing reports that IS_ERR_OR_NULL() should be matched with > PTR_ERR_OR_ZERO(), not PTR_ERR(). > > As it turns out, the error path always returns an error code, > i.e. NULL is never returned. > Update the code accordingly - s/IS_ERR_OR_NULL/IS_ERR. > > Reported-by: Wang Qing > Signed-off-by: Horia Geantă > --- > drivers/crypto/caam/caamalg_qi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt