From: Allen Pais <allen.lkml@gmail.com>
To: herbert@gondor.apana.org.au
Cc: davem@davemloft.net, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com,
jesper.nilsson@axis.com, lars.persson@axis.com,
horia.geanta@nxp.com, aymen.sghaier@nxp.com,
bbrezillon@kernel.org, arno@natisbad.org, schalla@marvell.com,
matthias.bgg@gmail.com, heiko@sntech.de, krzk@kernel.org,
vz@mleia.com, k.konieczny@samsung.com,
linux-crypto@vger.kernel.org, Allen Pais <apais@microsoft.com>,
Romain Perier <romain.perier@gmail.com>
Subject: [RESEND 17/19] crypto: s5p: convert tasklets to use new tasklet_setup() API
Date: Mon, 7 Dec 2020 14:29:29 +0530 [thread overview]
Message-ID: <20201207085931.661267-18-allen.lkml@gmail.com> (raw)
In-Reply-To: <20201207085931.661267-1-allen.lkml@gmail.com>
From: Allen Pais <apais@microsoft.com>
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <apais@microsoft.com>
---
drivers/crypto/s5p-sss.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 88a6c853ffd7..81d5222d5e63 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -1444,9 +1444,9 @@ static int s5p_hash_handle_queue(struct s5p_aes_dev *dd,
* s5p_hash_tasklet_cb() - hash tasklet
* @data: ptr to s5p_aes_dev
*/
-static void s5p_hash_tasklet_cb(unsigned long data)
+static void s5p_hash_tasklet_cb(struct tasklet_struct *t)
{
- struct s5p_aes_dev *dd = (struct s5p_aes_dev *)data;
+ struct s5p_aes_dev *dd = from_tasklet(dd, t, hash_tasklet);
if (!test_bit(HASH_FLAGS_BUSY, &dd->hash_flags)) {
s5p_hash_handle_queue(dd, NULL);
@@ -1974,9 +1974,9 @@ static void s5p_aes_crypt_start(struct s5p_aes_dev *dev, unsigned long mode)
s5p_aes_complete(req, err);
}
-static void s5p_tasklet_cb(unsigned long data)
+static void s5p_tasklet_cb(struct tasklet_struct *t)
{
- struct s5p_aes_dev *dev = (struct s5p_aes_dev *)data;
+ struct s5p_aes_dev *dev = from_tasklet(dev, t, tasklet);
struct crypto_async_request *async_req, *backlog;
struct s5p_aes_reqctx *reqctx;
unsigned long flags;
@@ -2257,7 +2257,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, pdata);
s5p_dev = pdata;
- tasklet_init(&pdata->tasklet, s5p_tasklet_cb, (unsigned long)pdata);
+ tasklet_setup(&pdata->tasklet, s5p_tasklet_cb);
crypto_init_queue(&pdata->queue, CRYPTO_QUEUE_LEN);
for (i = 0; i < ARRAY_SIZE(algs); i++) {
@@ -2267,8 +2267,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
}
if (pdata->use_hash) {
- tasklet_init(&pdata->hash_tasklet, s5p_hash_tasklet_cb,
- (unsigned long)pdata);
+ tasklet_setup(&pdata->hash_tasklet, s5p_hash_tasklet_cb);
crypto_init_queue(&pdata->hash_queue, SSS_HASH_QUEUE_LENGTH);
for (hash_i = 0; hash_i < ARRAY_SIZE(algs_sha1_md5_sha256);
--
2.25.1
next prev parent reply other threads:[~2020-12-07 9:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 8:59 [RESEND 00/19] crypto: convert tasklets to use new tasklet_setup API() Allen Pais
2020-12-07 8:59 ` [RESEND 01/19] crypto: amcc: convert tasklets to use new tasklet_setup() API Allen Pais
2020-12-07 8:59 ` [RESEND 02/19] crypto: atmel: " Allen Pais
2020-12-07 8:59 ` [RESEND 03/19] crypto: axis: " Allen Pais
2020-12-07 8:59 ` [RESEND 04/19] crypto: caam: " Allen Pais
2020-12-14 17:21 ` Horia Geantă
2020-12-07 8:59 ` [RESEND 05/19] crypto: cavium: " Allen Pais
2020-12-07 8:59 ` [RESEND 06/19] crypto: ccp: " Allen Pais
2020-12-07 8:59 ` [RESEND 07/19] crypto: ccree: " Allen Pais
2020-12-09 6:46 ` Gilad Ben-Yossef
2020-12-09 11:35 ` Allen
2020-12-07 8:59 ` [RESEND 08/19] crypto: hifn_795x: " Allen Pais
2020-12-07 8:59 ` [RESEND 09/19] crypto: img-hash: " Allen Pais
2020-12-07 8:59 ` [RESEND 10/19] crypto: ixp4xx: " Allen Pais
2020-12-07 8:59 ` [RESEND 11/19] crypto: mediatek: " Allen Pais
2020-12-07 8:59 ` [RESEND 12/19] crypto: omap: " Allen Pais
2020-12-07 8:59 ` [RESEND 13/19] crypto: picoxcell: " Allen Pais
2020-12-07 8:59 ` [RESEND 14/19] crypto: qat: " Allen Pais
2020-12-07 8:59 ` [RESEND 15/19] crypto: qce: " Allen Pais
2020-12-07 8:59 ` [RESEND 16/19] crypto: rockchip: " Allen Pais
2020-12-07 8:59 ` Allen Pais [this message]
2020-12-07 9:50 ` [RESEND 17/19] crypto: s5p: " Krzysztof Kozlowski
2020-12-07 8:59 ` [RESEND 18/19] crypto: talitos: " Allen Pais
2020-12-07 8:59 ` [RESEND 19/19] crypto: octeontx: " Allen Pais
2020-12-07 9:13 ` [RESEND 00/19] crypto: convert tasklets to use new tasklet_setup API() Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207085931.661267-18-allen.lkml@gmail.com \
--to=allen.lkml@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=apais@microsoft.com \
--cc=arno@natisbad.org \
--cc=aymen.sghaier@nxp.com \
--cc=bbrezillon@kernel.org \
--cc=davem@davemloft.net \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=jesper.nilsson@axis.com \
--cc=k.konieczny@samsung.com \
--cc=krzk@kernel.org \
--cc=lars.persson@axis.com \
--cc=linux-crypto@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=romain.perier@gmail.com \
--cc=schalla@marvell.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).