From: Allen Pais <allen.lkml@gmail.com>
To: herbert@gondor.apana.org.au
Cc: davem@davemloft.net, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com,
jesper.nilsson@axis.com, lars.persson@axis.com,
horia.geanta@nxp.com, aymen.sghaier@nxp.com,
bbrezillon@kernel.org, arno@natisbad.org, schalla@marvell.com,
matthias.bgg@gmail.com, heiko@sntech.de, krzk@kernel.org,
vz@mleia.com, k.konieczny@samsung.com,
linux-crypto@vger.kernel.org, Allen Pais <apais@microsoft.com>,
Romain Perier <romain.perier@gmail.com>
Subject: [RESEND 04/19] crypto: caam: convert tasklets to use new tasklet_setup() API
Date: Mon, 7 Dec 2020 14:29:16 +0530 [thread overview]
Message-ID: <20201207085931.661267-5-allen.lkml@gmail.com> (raw)
In-Reply-To: <20201207085931.661267-1-allen.lkml@gmail.com>
From: Allen Pais <apais@microsoft.com>
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <apais@microsoft.com>
---
drivers/crypto/caam/jr.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 6f669966ba2c..1b5939e42e67 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -9,6 +9,7 @@
#include <linux/of_irq.h>
#include <linux/of_address.h>
+#include <linux/interrupt.h>
#include "compat.h"
#include "ctrl.h"
@@ -201,11 +202,11 @@ static irqreturn_t caam_jr_interrupt(int irq, void *st_dev)
}
/* Deferred service handler, run as interrupt-fired tasklet */
-static void caam_jr_dequeue(unsigned long devarg)
+static void caam_jr_dequeue(struct tasklet_struct *t)
{
int hw_idx, sw_idx, i, head, tail;
- struct device *dev = (struct device *)devarg;
- struct caam_drv_private_jr *jrp = dev_get_drvdata(dev);
+ struct caam_drv_private_jr *jrp = from_tasklet(jrp, t, irqtask);
+ struct device *dev = jrp->dev;
void (*usercall)(struct device *dev, u32 *desc, u32 status, void *arg);
u32 *userdesc, userstatus;
void *userarg;
@@ -483,7 +484,7 @@ static int caam_jr_init(struct device *dev)
(JOBR_INTC_COUNT_THLD << JRCFG_ICDCT_SHIFT) |
(JOBR_INTC_TIME_THLD << JRCFG_ICTT_SHIFT));
- tasklet_init(&jrp->irqtask, caam_jr_dequeue, (unsigned long)dev);
+ tasklet_setup(&jrp->irqtask, caam_jr_dequeue);
/* Connect job ring interrupt handler. */
error = devm_request_irq(dev, jrp->irq, caam_jr_interrupt, IRQF_SHARED,
--
2.25.1
next prev parent reply other threads:[~2020-12-07 9:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 8:59 [RESEND 00/19] crypto: convert tasklets to use new tasklet_setup API() Allen Pais
2020-12-07 8:59 ` [RESEND 01/19] crypto: amcc: convert tasklets to use new tasklet_setup() API Allen Pais
2020-12-07 8:59 ` [RESEND 02/19] crypto: atmel: " Allen Pais
2020-12-07 8:59 ` [RESEND 03/19] crypto: axis: " Allen Pais
2020-12-07 8:59 ` Allen Pais [this message]
2020-12-14 17:21 ` [RESEND 04/19] crypto: caam: " Horia Geantă
2020-12-07 8:59 ` [RESEND 05/19] crypto: cavium: " Allen Pais
2020-12-07 8:59 ` [RESEND 06/19] crypto: ccp: " Allen Pais
2020-12-07 8:59 ` [RESEND 07/19] crypto: ccree: " Allen Pais
2020-12-09 6:46 ` Gilad Ben-Yossef
2020-12-09 11:35 ` Allen
2020-12-07 8:59 ` [RESEND 08/19] crypto: hifn_795x: " Allen Pais
2020-12-07 8:59 ` [RESEND 09/19] crypto: img-hash: " Allen Pais
2020-12-07 8:59 ` [RESEND 10/19] crypto: ixp4xx: " Allen Pais
2020-12-07 8:59 ` [RESEND 11/19] crypto: mediatek: " Allen Pais
2020-12-07 8:59 ` [RESEND 12/19] crypto: omap: " Allen Pais
2020-12-07 8:59 ` [RESEND 13/19] crypto: picoxcell: " Allen Pais
2020-12-07 8:59 ` [RESEND 14/19] crypto: qat: " Allen Pais
2020-12-07 8:59 ` [RESEND 15/19] crypto: qce: " Allen Pais
2020-12-07 8:59 ` [RESEND 16/19] crypto: rockchip: " Allen Pais
2020-12-07 8:59 ` [RESEND 17/19] crypto: s5p: " Allen Pais
2020-12-07 9:50 ` Krzysztof Kozlowski
2020-12-07 8:59 ` [RESEND 18/19] crypto: talitos: " Allen Pais
2020-12-07 8:59 ` [RESEND 19/19] crypto: octeontx: " Allen Pais
2020-12-07 9:13 ` [RESEND 00/19] crypto: convert tasklets to use new tasklet_setup API() Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207085931.661267-5-allen.lkml@gmail.com \
--to=allen.lkml@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=apais@microsoft.com \
--cc=arno@natisbad.org \
--cc=aymen.sghaier@nxp.com \
--cc=bbrezillon@kernel.org \
--cc=davem@davemloft.net \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=jesper.nilsson@axis.com \
--cc=k.konieczny@samsung.com \
--cc=krzk@kernel.org \
--cc=lars.persson@axis.com \
--cc=linux-crypto@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=romain.perier@gmail.com \
--cc=schalla@marvell.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).