From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 863AFC433E0 for ; Wed, 23 Dec 2020 08:54:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37B53206D6 for ; Wed, 23 Dec 2020 08:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727845AbgLWIx7 (ORCPT ); Wed, 23 Dec 2020 03:53:59 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:37094 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727050AbgLWIx7 (ORCPT ); Wed, 23 Dec 2020 03:53:59 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1krztS-0007XT-Ol; Wed, 23 Dec 2020 19:53:15 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Wed, 23 Dec 2020 19:53:14 +1100 Date: Wed, 23 Dec 2020 19:53:14 +1100 From: Herbert Xu To: Eric Biggers Cc: Ard Biesheuvel , linux-crypto@vger.kernel.org Subject: Re: [PATCH v2] crypto: arm/chacha-neon - add missing counter increment Message-ID: <20201223085314.GA16670@gondor.apana.org.au> References: <20201213143929.7088-1-ardb@kernel.org> <20201214022520.GA13534@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Dec 14, 2020 at 12:39:29PM -0800, Eric Biggers wrote: > > That doesn't make sense, given that most algorithms don't implement it... It doesn't matter for chacha, but it's still true for the Crypto API in general. Yes I know that lots of algorithms get it wrong, but it is on my list of things to fix. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt