Re: [PATCH v3 1/2] dt-bindings: crypto: Add Mediatek EIP-93 crypto engine

Rob Herring
2021-10-27T13:58:27Z

On Wed, Oct 27, 2021 at 4:13 AM Richard van Schagen <vschagen@icloud.com> wrote:
>
> Add bindings for the Mediatek EIP-93 crypto engine.

Please resend to DT list so automated checks run and it is in my review queue.

> Signed-off-by: Richard van Schagen <vschagen@icloud.com>
> ---
> Changes since V2:
> - Adding 2 missing "static" which got lost in my editing (sorry)
>
> Changes since V1
> - Add missing #include to examples
>
> .../bindings/crypto/mediatek,mtk-eip93.yaml | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/crypto/mediatek,mtk-eip93.yaml
>
> diff --git a/Documentation/devicetree/bindings/crypto/mediatek,mtk-eip93.yaml b/Documentation/devicetree/bindings/crypto/mediatek,mtk-eip93.yaml
> new file mode 100644
> index 000000000..422870afb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/mediatek,mtk-eip93.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/mediatek,mtk-eip93.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek EIP93 crypto engine
> +
> +maintainers:
> + - Richard van Schagen <vschagen@icloud.com>
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek, mtk-eip93

Looks like a typo. 'make dt_binding_check' would have pointed this out.

> +
> + reg:
> + maxItems: 1
> +
> + interrupts-parent:
> + maxItems: 1

Drop this. First, it's 'interrupt-parent'. Second, it is valid for
interrupt-parent to be in any parent node as well. So you don't need
to define it here.

> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupt-parent
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/mips-gic.h>
> +
> + crypto: crypto@1e004000 {
> + compatible = "mediatek,mtk-eip93";
> + reg = <0x1e004000 0x1000>;
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_SHARED 19 IRQ_TYPE_LEVEL_HIGH>;
> + };
> --
> 2.30.2
>