public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
* Re: crypto: api - Fix boot-up crash when crypto manager is disabled
@ 2021-11-05 13:26 Guenter Roeck
  0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2021-11-05 13:26 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Ido Schimmel, Geert Uytterhoeven, Damien Le Moal,
	Nathan Chancellor, Linux Crypto Mailing List, Vladis Dronov,
	Simo Sorce, Eric Biggers, llvm@lists.linux.dev, kernel test robot,
	linux-kernel@vger.kernel.org

On Fri, Nov 05, 2021 at 03:26:08PM +0800, Herbert Xu wrote:
> On Thu, Nov 04, 2021 at 05:18:34PM +0200, Ido Schimmel wrote:
> >
> > Attached my config. I can easily test patches.
> 
> Thanks!
> 
> Could you all try this patch please?
> 
> ---8<---
> When the crypto manager is disabled, we need to explicitly set
> the crypto algorithms' tested status so that they can be used.
> 
> Fixes: cad439fc040e ("crypto: api - Do not create test larvals if...")
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reported-by: Ido Schimmel <idosch@idosch.org>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> 
> diff --git a/crypto/algapi.c b/crypto/algapi.c
> index d379fd91fb7b..a366cb3e8aa1 100644
> --- a/crypto/algapi.c
> +++ b/crypto/algapi.c
> @@ -284,6 +284,8 @@ static struct crypto_larval *__crypto_register_alg(struct crypto_alg *alg)
>  
>  	if (larval)
>  		list_add(&larval->alg.cra_list, &crypto_alg_list);
> +	else
> +		alg->cra_flags |= CRYPTO_ALG_TESTED;
>  
>  	crypto_stats_init(alg);
>  
> -- 
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [v2 PATCH] crypto: api - Fix built-in testing dependency failures
@ 2021-10-03  0:28 Herbert Xu
  2021-10-06  2:33 ` Nathan Chancellor
  0 siblings, 1 reply; 4+ messages in thread
From: Herbert Xu @ 2021-10-03  0:28 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: Linux Crypto Mailing List, Vladis Dronov, Simo Sorce,
	Eric Biggers, llvm

On Fri, Oct 01, 2021 at 11:01:59AM -0700, Nathan Chancellor wrote:
>
> I have attached the Kconfig file that I used to reproduce it. It is
> still reproducible for me at your latest commit in cryptodev
> (e42dff467ee688fe6b5a083f1837d06e3b27d8c0) with that exact command that
> I gave you.
> 
> It is possible that it could be crypto_boot_test_finished?

I don't think that's the issue because algapi already depends on
api.  However, the softdep on cryptomgr in api looks suspicious,
as it would always introduce a loop.  Can you try removing that
softdep from api.c and see if the problem resolves it self?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-05 18:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-05 13:26 crypto: api - Fix boot-up crash when crypto manager is disabled Guenter Roeck
  -- strict thread matches above, loose matches on Subject: below --
2021-10-03  0:28 [v2 PATCH] crypto: api - Fix built-in testing dependency failures Herbert Xu
2021-10-06  2:33 ` Nathan Chancellor
2021-10-19 13:28   ` [PATCH] crypto: api - Do not create test larvals if manager is disabled Herbert Xu
2021-11-02 15:41     ` Geert Uytterhoeven
2021-11-04  7:28       ` Damien Le Moal
2021-11-04  7:58         ` Geert Uytterhoeven
2021-11-04 12:16           ` Herbert Xu
2021-11-04 13:11             ` Geert Uytterhoeven
2021-11-04 13:30               ` Herbert Xu
2021-11-04 15:18                 ` Ido Schimmel
2021-11-05  7:26                   ` crypto: api - Fix boot-up crash when crypto " Herbert Xu
2021-11-05 14:33                     ` Ido Schimmel
2021-11-05 18:00                     ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox