* [PATCH] crypto: qat - fix a signedness bug in get_service_enabled()
@ 2022-01-11 7:18 Dan Carpenter
2022-01-11 12:05 ` Giovanni Cabiddu
2022-01-28 6:23 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-01-11 7:18 UTC (permalink / raw)
To: Giovanni Cabiddu, Tomasz Kowalik
Cc: Herbert Xu, David S. Miller, Marco Chiappero, Fiona Trahe,
Wojciech Ziemba, Mateuszx Potrola, qat-linux, linux-crypto,
kernel-janitors
The "ret" variable needs to be signed or there is an error message which
will not be printed correctly.
Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
index 6d10edc40aca..68d39c833332 100644
--- a/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
+++ b/drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c
@@ -52,7 +52,7 @@ static const char *const dev_cfg_services[] = {
static int get_service_enabled(struct adf_accel_dev *accel_dev)
{
char services[ADF_CFG_MAX_VAL_LEN_IN_BYTES] = {0};
- u32 ret;
+ int ret;
ret = adf_cfg_get_param_value(accel_dev, ADF_GENERAL_SEC,
ADF_SERVICES_ENABLED, services);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: qat - fix a signedness bug in get_service_enabled()
2022-01-11 7:18 [PATCH] crypto: qat - fix a signedness bug in get_service_enabled() Dan Carpenter
@ 2022-01-11 12:05 ` Giovanni Cabiddu
2022-01-28 6:23 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Giovanni Cabiddu @ 2022-01-11 12:05 UTC (permalink / raw)
To: Dan Carpenter, Herbert Xu
Cc: Tomasz Kowalik, David S. Miller, Marco Chiappero, Fiona Trahe,
Wojciech Ziemba, Mateuszx Potrola, qat-linux, linux-crypto,
kernel-janitors
On Tue, Jan 11, 2022 at 10:18:06AM +0300, Dan Carpenter wrote:
> The "ret" variable needs to be signed or there is an error message which
> will not be printed correctly.
>
> Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan.
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
@Herbert, there are 2 other (identical) patches in the list that fix the
same issue:
https://patchwork.kernel.org/project/linux-crypto/patch/YdWZm6QJAYbYTKAR@debian-BULLSEYE-live-builder-AMD64/
https://patchwork.kernel.org/project/linux-crypto/patch/20220105152005.43305-1-jiapeng.chong@linux.alibaba.com/
Since none of them made into the pull request for 5.17, I'm fine with
taking this one as it is the only one which contains the Fixes tag.
Regards,
--
Giovanni
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: qat - fix a signedness bug in get_service_enabled()
2022-01-11 7:18 [PATCH] crypto: qat - fix a signedness bug in get_service_enabled() Dan Carpenter
2022-01-11 12:05 ` Giovanni Cabiddu
@ 2022-01-28 6:23 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2022-01-28 6:23 UTC (permalink / raw)
To: Dan Carpenter
Cc: Giovanni Cabiddu, Tomasz Kowalik, David S. Miller,
Marco Chiappero, Fiona Trahe, Wojciech Ziemba, Mateuszx Potrola,
qat-linux, linux-crypto, kernel-janitors
On Tue, Jan 11, 2022 at 10:18:06AM +0300, Dan Carpenter wrote:
> The "ret" variable needs to be signed or there is an error message which
> will not be printed correctly.
>
> Fixes: 0cec19c761e5 ("crypto: qat - add support for compression for 4xxx")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-28 6:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-11 7:18 [PATCH] crypto: qat - fix a signedness bug in get_service_enabled() Dan Carpenter
2022-01-11 12:05 ` Giovanni Cabiddu
2022-01-28 6:23 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).