From: Keith Busch <kbusch@kernel.org>
To: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-crypto@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Cc: axboe@kernel.dk, hch@lst.de, martin.petersen@oracle.com,
colyli@suse.de, Keith Busch <kbusch@kernel.org>
Subject: [PATCHv3 00/10] 64-bit data integrity field support
Date: Tue, 22 Feb 2022 08:31:34 -0800 [thread overview]
Message-ID: <20220222163144.1782447-1-kbusch@kernel.org> (raw)
The NVM Express protocol added enhancements to the data integrity field
formats beyond the T10 defined protection information. A detailed
description of the new formats can be found in the NVMe's NVM Command
Set Specification, section 5.2, available at:
https://nvmexpress.org/wp-content/uploads/NVM-Command-Set-Specification-1.0b-2021.12.18-Ratified.pdf
This series implements one possible new format: the CRC64 guard with
48-bit reference tags. This does not add support for the variable
"storage tag" field, or any potential hardware acceleration.
Changes since v2:
Introduced lower_48_bits() (Bart)
Added "64" suffix to crc names to distinguish from other crc
calculations (Martin)
Added module support to crypto library, and have the integrity
generate/verify use that instead of directly calling the generic table
lookup implementation. This is modeled after the t10 implementation.
Added an x86 pclmul accelerated crc64 calculation
Added speed tests to the test module so that the generic and library
function could be compared.
Bug fix in nvme to select the correct integrity profile.
Added reviews
Note, I am not particularly well versed with x86 assembly, so I'm reasonably
sure that the pcl implementation could be improved. It currently is
about 20x faster than the generic implementation, but I believe it could
be over 30x faster if done more efficiently.
Keith Busch (10):
block: support pi with extended metadata
nvme: allow integrity on extended metadata formats
asm-generic: introduce be48 unaligned accessors
linux/kernel: introduce lower_48_bits macro
lib: add rocksoft model crc64
crypto: add rocksoft 64b crc guard tag framework
lib: add crc64 tests
block: add pi for nvme enhanced integrity
nvme: add support for enhanced metadata
x86/crypto: add pclmul acceleration for crc64
arch/x86/crypto/Makefile | 3 +
arch/x86/crypto/crc64-rocksoft-pcl-asm.S | 215 ++++++++++++++++++++++
arch/x86/crypto/crc64-rocksoft-pcl_glue.c | 117 ++++++++++++
block/Kconfig | 1 +
block/bio-integrity.c | 1 +
block/t10-pi.c | 198 +++++++++++++++++++-
crypto/Kconfig | 20 ++
crypto/Makefile | 1 +
crypto/crc64_rocksoft_generic.c | 104 +++++++++++
drivers/nvme/host/core.c | 175 ++++++++++++++----
drivers/nvme/host/nvme.h | 4 +-
include/asm-generic/unaligned.h | 26 +++
include/linux/blk-integrity.h | 1 +
include/linux/crc64.h | 7 +
include/linux/kernel.h | 6 +
include/linux/nvme.h | 53 +++++-
include/linux/t10-pi.h | 20 ++
lib/Kconfig | 9 +
lib/Kconfig.debug | 4 +
lib/Makefile | 2 +
lib/crc64-rocksoft.c | 129 +++++++++++++
lib/crc64.c | 26 +++
lib/gen_crc64table.c | 51 +++--
lib/test_crc64.c | 133 +++++++++++++
24 files changed, 1252 insertions(+), 54 deletions(-)
create mode 100644 arch/x86/crypto/crc64-rocksoft-pcl-asm.S
create mode 100644 arch/x86/crypto/crc64-rocksoft-pcl_glue.c
create mode 100644 crypto/crc64_rocksoft_generic.c
create mode 100644 lib/crc64-rocksoft.c
create mode 100644 lib/test_crc64.c
--
2.25.4
next reply other threads:[~2022-02-22 16:32 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 16:31 Keith Busch [this message]
2022-02-22 16:31 ` [PATCHv3 01/10] block: support pi with extended metadata Keith Busch
2022-02-25 16:01 ` Christoph Hellwig
2022-02-22 16:31 ` [PATCHv3 02/10] nvme: allow integrity on extended metadata formats Keith Busch
2022-02-25 16:02 ` Christoph Hellwig
2022-02-22 16:31 ` [PATCHv3 03/10] asm-generic: introduce be48 unaligned accessors Keith Busch
2022-02-22 16:52 ` Chaitanya Kulkarni
2022-02-25 16:03 ` Christoph Hellwig
2022-02-25 17:53 ` Joe Perches
2022-02-25 17:59 ` Keith Busch
2022-02-22 16:31 ` [PATCHv3 04/10] linux/kernel: introduce lower_48_bits macro Keith Busch
2022-02-22 16:45 ` Joe Perches
2022-02-22 16:50 ` Christoph Hellwig
2022-02-22 16:56 ` Keith Busch
2022-02-22 18:43 ` Joe Perches
2022-02-22 20:09 ` David Laight
2022-02-22 20:31 ` Joe Perches
2022-02-22 21:12 ` Keith Busch
2022-02-22 21:17 ` Joe Perches
2022-02-22 16:58 ` Joe Perches
2022-02-22 17:09 ` David Laight
2022-02-22 17:14 ` Chaitanya Kulkarni
2022-02-22 16:48 ` Chaitanya Kulkarni
2022-02-22 16:31 ` [PATCHv3 05/10] lib: add rocksoft model crc64 Keith Busch
2022-02-25 16:04 ` Christoph Hellwig
2022-02-22 16:31 ` [PATCHv3 06/10] crypto: add rocksoft 64b crc framework Keith Busch
2022-02-22 19:50 ` Eric Biggers
2022-02-22 19:54 ` Eric Biggers
2022-02-22 20:09 ` Keith Busch
2022-02-25 16:11 ` Christoph Hellwig
2022-02-22 19:56 ` Eric Biggers
2022-02-22 16:31 ` [PATCHv3 07/10] lib: add crc64 tests Keith Busch
2022-02-22 16:50 ` Chaitanya Kulkarni
2022-02-25 16:05 ` Christoph Hellwig
2022-02-25 16:12 ` Keith Busch
2022-02-25 16:19 ` Christoph Hellwig
2022-02-22 16:31 ` [PATCHv3 08/10] block: add pi for nvme enhanced integrity Keith Busch
2022-02-25 16:14 ` Christoph Hellwig
2022-03-02 3:15 ` Martin K. Petersen
2022-02-22 16:31 ` [PATCHv3 09/10] nvme: add support for enhanced metadata Keith Busch
2022-02-25 16:17 ` Christoph Hellwig
2022-03-02 3:18 ` Martin K. Petersen
2022-02-22 16:31 ` [PATCHv3 10/10] x86/crypto: add pclmul acceleration for crc64 Keith Busch
2022-02-22 17:02 ` David Laight
2022-02-22 17:14 ` Keith Busch
2022-02-22 20:06 ` Eric Biggers
2022-02-22 20:51 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222163144.1782447-1-kbusch@kernel.org \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).