From: Jason Gunthorpe <jgg@nvidia.com>
To: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, alex.williamson@redhat.com,
cohuck@redhat.com, mgurtovoy@nvidia.com, yishaih@nvidia.com,
linuxarm@huawei.com, liulongfang@huawei.com,
prime.zeng@hisilicon.com, jonathan.cameron@huawei.com,
wangzhou1@hisilicon.com
Subject: Re: [PATCH v5 7/8] hisi_acc_vfio_pci: Add support for VFIO live migration
Date: Tue, 22 Feb 2022 20:52:51 -0400 [thread overview]
Message-ID: <20220223005251.GJ10061@nvidia.com> (raw)
In-Reply-To: <20220221114043.2030-8-shameerali.kolothum.thodi@huawei.com>
On Mon, Feb 21, 2022 at 11:40:42AM +0000, Shameer Kolothum wrote:
> + /*
> + * ACC VF dev BAR2 region consists of both functional register space
> + * and migration control register space. For migration to work, we
> + * need access to both. Hence, we map the entire BAR2 region here.
> + * But from a security point of view, we restrict access to the
> + * migration control space from Guest(Please see mmap/ioctl/read/write
> + * override functions).
> + *
> + * Also the HiSilicon ACC VF devices supported by this driver on
> + * HiSilicon hardware platforms are integrated end point devices
> + * and has no capability to perform PCIe P2P.
If that is the case why not implement the RUNNING_P2P as well as a
NOP?
Alex expressed concerned about proliferation of non-P2P devices as it
complicates qemu to support mixes
Jason
next prev parent reply other threads:[~2022-02-23 0:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 11:40 [PATCH v5 0/8] vfio/hisilicon: add ACC live migration driver Shameer Kolothum
2022-02-21 11:40 ` [PATCH v5 1/8] crypto: hisilicon/qm: Move the QM header to include/linux Shameer Kolothum
2022-02-21 11:40 ` [PATCH v5 2/8] crypto: hisilicon/qm: Move few definitions to common header Shameer Kolothum
2022-02-21 11:40 ` [PATCH v5 3/8] hisi_acc_qm: Move PCI device IDs " Shameer Kolothum
2022-02-21 11:40 ` [PATCH v5 4/8] hisi_acc_vfio_pci: add new vfio_pci driver for HiSilicon ACC devices Shameer Kolothum
2022-02-21 11:40 ` [PATCH v5 5/8] hisi_acc_vfio_pci: Restrict access to VF dev BAR2 migration region Shameer Kolothum
2022-02-23 23:37 ` Alex Williamson
2022-02-21 11:40 ` [PATCH v5 6/8] hisi_acc_vfio_pci: Add helper to retrieve the PF qm data Shameer Kolothum
2022-02-23 23:37 ` Alex Williamson
2022-02-21 11:40 ` [PATCH v5 7/8] hisi_acc_vfio_pci: Add support for VFIO live migration Shameer Kolothum
2022-02-23 0:52 ` Jason Gunthorpe [this message]
2022-02-23 15:58 ` Shameerali Kolothum Thodi
2022-02-23 16:34 ` Alex Williamson
2022-02-23 17:07 ` Shameerali Kolothum Thodi
2022-02-23 17:52 ` Jason Gunthorpe
2022-02-23 23:38 ` Alex Williamson
2022-02-21 11:40 ` [PATCH v5 8/8] hisi_acc_vfio_pci: Use its own PCI reset_done error handler Shameer Kolothum
2022-02-22 0:49 ` [PATCH v5 0/8] vfio/hisilicon: add ACC live migration driver Jason Gunthorpe
2022-02-22 19:29 ` Alex Williamson
2022-02-23 15:53 ` Shameerali Kolothum Thodi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223005251.GJ10061@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liulongfang@huawei.com \
--cc=mgurtovoy@nvidia.com \
--cc=prime.zeng@hisilicon.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).