From: Denis Glazkov <d.glazkov@omp.ru>
To: unlisted-recipients:; (no To-header on input)
Cc: Denis Glazkov <d.glazkov@omp.ru>,
David Howells <dhowells@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] PKCS#7: fix a possible memory leak when calculating the digest
Date: Thu, 24 Feb 2022 19:09:12 +0000 [thread overview]
Message-ID: <20220224190838.144388-1-d.glazkov@omp.ru> (raw)
In function `pkcs7_digest`, if there is an error allocating memory
for the `shash_desc` structure, the public key signature digest
remains unfreed.
Signed-off-by: Denis Glazkov <d.glazkov@omp.ru>
---
crypto/asymmetric_keys/pkcs7_verify.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/crypto/asymmetric_keys/pkcs7_verify.c b/crypto/asymmetric_keys/pkcs7_verify.c
index 0b4d07aa8811..e6f648dcc02a 100644
--- a/crypto/asymmetric_keys/pkcs7_verify.c
+++ b/crypto/asymmetric_keys/pkcs7_verify.c
@@ -50,7 +50,7 @@ static int pkcs7_digest(struct pkcs7_message *pkcs7,
ret = -ENOMEM;
sig->digest = kmalloc(sig->digest_size, GFP_KERNEL);
if (!sig->digest)
- goto error_no_desc;
+ goto error_no_digest;
desc = kzalloc(desc_size, GFP_KERNEL);
if (!desc)
@@ -117,6 +117,8 @@ static int pkcs7_digest(struct pkcs7_message *pkcs7,
error:
kfree(desc);
error_no_desc:
+ kfree(sig->digest);
+error_no_digest:
crypto_free_shash(tfm);
kleave(" = %d", ret);
return ret;
--
2.25.1
next reply other threads:[~2022-02-24 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 19:09 Denis Glazkov [this message]
2022-02-24 19:34 ` [PATCH] PKCS#7: fix a possible memory leak when calculating the digest Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224190838.144388-1-d.glazkov@omp.ru \
--to=d.glazkov@omp.ru \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox