linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] raid6test: change dataoffs from global to static
@ 2022-04-03 13:30 Tom Rix
  0 siblings, 0 replies; only message in thread
From: Tom Rix @ 2022-04-03 13:30 UTC (permalink / raw)
  To: dan.j.williams, herbert, davem, jarkko
  Cc: linux-crypto, linux-kernel, Tom Rix

Smatch reports this issue
raid6test.c:21:14: warning: symbol 'dataoffs'
  was not declared. Should it be static?

dataoffs is only used in raid6test.c.  File
scope variables used only in one file should
be static. Change dataoffs' storage-class-specifier
from global to static.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 crypto/async_tx/raid6test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/async_tx/raid6test.c b/crypto/async_tx/raid6test.c
index c9d218e53bcb..d2d5fb154cda 100644
--- a/crypto/async_tx/raid6test.c
+++ b/crypto/async_tx/raid6test.c
@@ -18,7 +18,7 @@
 #define NDISKS 64 /* Including P and Q */
 
 static struct page *dataptrs[NDISKS];
-unsigned int dataoffs[NDISKS];
+static unsigned int dataoffs[NDISKS];
 static addr_conv_t addr_conv[NDISKS];
 static struct page *data[NDISKS+3];
 static struct page *spare;
-- 
2.27.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-04-03 13:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-03 13:30 [PATCH] raid6test: change dataoffs from global to static Tom Rix

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).