Re: [PATCH v6 25/33] dt-bindings: crypto: rockchip: convert to new driver bindings

Krzysztof Kozlowski
2022-04-26T07:17:12Z

On 25/04/2022 22:21, Corentin Labbe wrote:
> The latest addition to the rockchip crypto driver need to update the
> driver bindings.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> .../crypto/rockchip,rk3288-crypto.yaml | 85 +++++++++++++++++--
> 1 file changed, 77 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> index 8a219d439d02..ad604d7e4bc0 100644
> --- a/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> @@ -13,6 +13,8 @@ properties:
> compatible:
> enum:
> - rockchip,rk3288-crypto
> + - rockchip,rk3328-crypto
> + - rockchip,rk3399-crypto
>
> reg:
> maxItems: 1
> @@ -21,21 +23,88 @@ properties:
> maxItems: 1
>
> clocks:
> + minItems: 3
> maxItems: 4
>
> clock-names:
> - items:
> - - const: aclk
> - - const: hclk
> - - const: sclk
> - - const: apb_pclk
> + minItems: 3
> + maxItems: 4
>
> resets:
> - maxItems: 1
> + minItems: 1
> + maxItems: 3
>
> reset-names:
> - items:
> - - const: crypto-rst
> + minItems: 1
> + maxItems: 3
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: rockchip,rk3288-crypto
> + then:
> + properties:
> + clocks:
> + minItems: 4
> + clock-names:
> + items:
> + - const: "aclk"

No quotes (here and other places).

Rest looks good.

Best regards,
Krzysztof