Re: [PATCH 1/2] hwrng: stm32 - fix number of returned bytes on read

Tomas Marek
2022-10-25T14:42:15Z

On Fri, Oct 21, 2022 at 06:41:07PM +0800, Herbert Xu wrote:
> On Wed, Oct 12, 2022 at 06:09:23PM +0200, Tomas Marek wrote:
> >
> > diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c
> > index bc22178f83e8..8eaacefd498b 100644
> > --- a/drivers/char/hw_random/stm32-rng.c
> > +++ b/drivers/char/hw_random/stm32-rng.c
> > @@ -49,11 +49,13 @@ static int stm32_rng_read(struct hwrng *rng, void *data, size_t max, bool wait)
> > /* Manage timeout which is based on timer and take */
> > /* care of initial delay time when enabling rng */
> > if (!sr && wait) {
> > - retval = readl_relaxed_poll_timeout_atomic(priv->base
> > + int ret;
> > +
> > + ret = readl_relaxed_poll_timeout_atomic(priv->base
>
> This would make a lot more sense if you called it err instead of ret.
>
> But as you're fixing a real bug I'm going to apply your patch as is
> and you can post an incremental patch to improve it.

OK, sounds reasonable. I'll post new patch and rename ret to err.

Thanks for the hint and for the review.

Tomas

>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt