From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: [PATCH] hw_random: use add_hwgenerator_randomness() for early entropy
Date: Sat, 5 Nov 2022 21:44:17 +0100 [thread overview]
Message-ID: <20221105204417.137001-1-Jason@zx2c4.com> (raw)
Rather than calling add_device_randomness(), the add_early_randomness()
function should use add_hwgenerator_randomness(), so that the early
entropy can be potentially credited, which allows for the RNG to
initialize earlier without having to wait for the kthread to come up.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
drivers/char/hw_random/core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index cc002b0c2f0c..8c0819ce2781 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -69,8 +69,10 @@ static void add_early_randomness(struct hwrng *rng)
mutex_lock(&reading_mutex);
bytes_read = rng_get_data(rng, rng_fillbuf, 32, 0);
mutex_unlock(&reading_mutex);
- if (bytes_read > 0)
- add_device_randomness(rng_fillbuf, bytes_read);
+ if (bytes_read > 0) {
+ size_t entropy = bytes_read * 8 * rng->quality / 1024;
+ add_hwgenerator_randomness(rng_fillbuf, bytes_read, entropy);
+ }
}
static inline void cleanup_rng(struct kref *kref)
--
2.38.1
next reply other threads:[~2022-11-05 20:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 20:44 Jason A. Donenfeld [this message]
2022-11-06 1:31 ` [PATCH] hw_random: use add_hwgenerator_randomness() for early entropy Jason A. Donenfeld
2022-11-06 1:50 ` [PATCH v2] " Jason A. Donenfeld
2022-11-06 7:02 ` Dominik Brodowski
2022-11-06 14:50 ` Jason A. Donenfeld
2022-11-06 15:02 ` [PATCH v3] " Jason A. Donenfeld
2022-11-07 2:17 ` Herbert Xu
2022-11-07 12:55 ` Jason A. Donenfeld
2022-11-08 9:58 ` Herbert Xu
2022-11-07 7:39 ` Dominik Brodowski
2022-11-08 10:53 ` AngeloGioacchino Del Regno
2022-11-08 11:00 ` Jason A. Donenfeld
2022-11-08 11:24 ` [PATCH v4] " Jason A. Donenfeld
2022-11-08 11:44 ` AngeloGioacchino Del Regno
2022-11-08 22:05 ` Marek Szyprowski
2022-11-13 13:48 ` [PATCH v3] " kernel test robot
2022-11-13 14:11 ` Jason A. Donenfeld
2022-11-07 7:37 ` [PATCH v2] " Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221105204417.137001-1-Jason@zx2c4.com \
--to=jason@zx2c4.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).