From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev, 'Guanjun' <guanjun@linux.alibaba.com>,
herbert@gondor.apana.org.au, elliott@hpe.com
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
zelin.deng@linux.alibaba.com, artie.ding@linux.alibaba.com,
guanjun@linux.alibaba.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, xuchun.shang@linux.alibaba.com
Subject: Re: [PATCH v3 RESEND 2/9] crypto/ycc: Add ycc ring configuration
Date: Mon, 7 Nov 2022 10:46:19 +0300 [thread overview]
Message-ID: <202211052204.2NexxC29-lkp@intel.com> (raw)
In-Reply-To: <1667461243-48652-3-git-send-email-guanjun@linux.alibaba.com>
Hi 'Guanjun',
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Guanjun/Drivers-for-Alibaba-YCC-Yitian-Cryptography-Complex-cryptographic-accelerator/20221103-154448
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link: https://lore.kernel.org/r/1667461243-48652-3-git-send-email-guanjun%40linux.alibaba.com
patch subject: [PATCH v3 RESEND 2/9] crypto/ycc: Add ycc ring configuration
config: ia64-randconfig-m031-20221104
compiler: ia64-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
drivers/crypto/ycc/ycc_ring.c:132 ycc_create_ring_debugfs() warn: passing zero to 'PTR_ERR'
drivers/crypto/ycc/ycc_ring.c:381 ycc_select_ring() warn: variable dereferenced before check 'found' (see line 374)
vim +/PTR_ERR +132 drivers/crypto/ycc/ycc_ring.c
9f7d1fe6059378 Zelin Deng 2022-11-03 101 static int ycc_create_ring_debugfs(struct ycc_ring *ring)
9f7d1fe6059378 Zelin Deng 2022-11-03 102 {
9f7d1fe6059378 Zelin Deng 2022-11-03 103 struct dentry *debugfs;
9f7d1fe6059378 Zelin Deng 2022-11-03 104 char name[8];
9f7d1fe6059378 Zelin Deng 2022-11-03 105
9f7d1fe6059378 Zelin Deng 2022-11-03 106 if (!ring || !ring->ydev || !ring->ydev->debug_dir)
9f7d1fe6059378 Zelin Deng 2022-11-03 107 return -EINVAL;
9f7d1fe6059378 Zelin Deng 2022-11-03 108
9f7d1fe6059378 Zelin Deng 2022-11-03 109 snprintf(name, sizeof(name), "ring%02d", ring->ring_id);
9f7d1fe6059378 Zelin Deng 2022-11-03 110 debugfs = debugfs_create_dir(name, ring->ydev->debug_dir);
9f7d1fe6059378 Zelin Deng 2022-11-03 111 if (IS_ERR_OR_NULL(debugfs))
9f7d1fe6059378 Zelin Deng 2022-11-03 112 goto out;
9f7d1fe6059378 Zelin Deng 2022-11-03 113
9f7d1fe6059378 Zelin Deng 2022-11-03 114 ring->debug_dir = debugfs;
The static checker is correct to complain. Debugfs code is not required
to be checked. It should just be:
ring->debug_dir = debugfs_create_dir(name, ring->ydev->debug_dir);
debugfs_create_file("status", 0400, ring->debug_dir, (void *)ring,
&ycc_ring_status_fops);
debugfs_create_file("dump", 0400, ring->debug_dir, (void *)ring,
&ycc_ring_dump_fops);
return 0;
9f7d1fe6059378 Zelin Deng 2022-11-03 115
9f7d1fe6059378 Zelin Deng 2022-11-03 116 debugfs = debugfs_create_file("status", 0400, ring->debug_dir,
9f7d1fe6059378 Zelin Deng 2022-11-03 117 (void *)ring, &ycc_ring_status_fops);
9f7d1fe6059378 Zelin Deng 2022-11-03 118 if (IS_ERR_OR_NULL(debugfs))
9f7d1fe6059378 Zelin Deng 2022-11-03 119 goto remove_debugfs;
9f7d1fe6059378 Zelin Deng 2022-11-03 120
9f7d1fe6059378 Zelin Deng 2022-11-03 121 debugfs = debugfs_create_file("dump", 0400, ring->debug_dir,
9f7d1fe6059378 Zelin Deng 2022-11-03 122 (void *)ring, &ycc_ring_dump_fops);
9f7d1fe6059378 Zelin Deng 2022-11-03 123 if (IS_ERR_OR_NULL(debugfs))
9f7d1fe6059378 Zelin Deng 2022-11-03 124 goto remove_debugfs;
9f7d1fe6059378 Zelin Deng 2022-11-03 125
9f7d1fe6059378 Zelin Deng 2022-11-03 126 return 0;
9f7d1fe6059378 Zelin Deng 2022-11-03 127
9f7d1fe6059378 Zelin Deng 2022-11-03 128 remove_debugfs:
9f7d1fe6059378 Zelin Deng 2022-11-03 129 debugfs_remove_recursive(ring->debug_dir);
9f7d1fe6059378 Zelin Deng 2022-11-03 130 out:
9f7d1fe6059378 Zelin Deng 2022-11-03 131 ring->debug_dir = NULL;
9f7d1fe6059378 Zelin Deng 2022-11-03 @132 return PTR_ERR(debugfs);
9f7d1fe6059378 Zelin Deng 2022-11-03 133 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-11-07 7:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 7:40 [PATCH v3 RESEND 0/9] Drivers for Alibaba YCC (Yitian Cryptography Complex) cryptographic accelerator 'Guanjun'
2022-11-03 7:40 ` [PATCH v3 RESEND 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex) accelerator driver 'Guanjun'
2022-11-03 7:40 ` [PATCH v3 RESEND 2/9] crypto/ycc: Add ycc ring configuration 'Guanjun'
2022-11-07 7:46 ` Dan Carpenter [this message]
2022-11-07 13:28 ` kernel test robot
2022-11-09 20:25 ` kernel test robot
2022-11-03 7:40 ` [PATCH v3 RESEND 3/9] crypto/ycc: Add irq support for ycc kernel rings 'Guanjun'
2022-11-07 7:50 ` Dan Carpenter
2022-11-10 1:28 ` kernel test robot
2022-11-03 7:40 ` [PATCH v3 RESEND 4/9] crypto/ycc: Add device error handling support for ycc hw errors 'Guanjun'
2022-11-10 5:51 ` kernel test robot
2022-11-03 7:40 ` [PATCH v3 RESEND 5/9] crypto/ycc: Add skcipher algorithm support 'Guanjun'
2022-11-03 7:40 ` [PATCH v3 RESEND 6/9] crypto/ycc: Add aead " 'Guanjun'
2022-11-03 7:40 ` [PATCH v3 RESEND 7/9] crypto/ycc: Add rsa " 'Guanjun'
2022-11-03 7:40 ` [PATCH v3 RESEND 8/9] crypto/ycc: Add sm2 " 'Guanjun'
2022-11-07 8:01 ` Dan Carpenter
2022-11-03 7:40 ` [PATCH v3 RESEND 9/9] MAINTAINERS: Add Yitian Cryptography Complex (YCC) driver maintainer entry 'Guanjun'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202211052204.2NexxC29-lkp@intel.com \
--to=error27@gmail.com \
--cc=artie.ding@linux.alibaba.com \
--cc=elliott@hpe.com \
--cc=guanjun@linux.alibaba.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=xuchun.shang@linux.alibaba.com \
--cc=zelin.deng@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).