From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9120C76196 for ; Tue, 28 Mar 2023 17:40:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229555AbjC1Rky (ORCPT ); Tue, 28 Mar 2023 13:40:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbjC1Rko (ORCPT ); Tue, 28 Mar 2023 13:40:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8844E38D for ; Tue, 28 Mar 2023 10:40:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 39EAEB81DA3 for ; Tue, 28 Mar 2023 17:40:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D979EC433D2; Tue, 28 Mar 2023 17:40:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680025240; bh=oNbDgjbCH2Wv8j2byyR9OfjH3nCraTfNuG0EOkqirHU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dd91MVwnmRHXhgSojtV8FPq00biDqi65/nd7mXJGNnl+O9SKNbJvy6nBVvayA9tZ8 sStlNLU70zZWOrNpcuwIBZDj+qIqgv6iPVSI5Q7sUddY7SAttL6zg3pOEB/Ds4UaZw 1XPwtsA3926zOjbux2stlgA3lPGovHhbmeMwdoitrtcFkZld9CiZFt8yxhBP1X3Hm+ ETu8QxwexLGxM8WDC7KxfyH7+V2Z3YUfHRIEy0lXYGWjvLPW3GFR5rfw0WxUVCm/x8 /ohrr84R4fZ55rG7cckwNfylFBhNpD6edZkKEgpf7OcyDi2OTLR4njfluh/UuLjJfL C5T1twCm3pQCA== Date: Tue, 28 Mar 2023 10:40:38 -0700 From: Eric Biggers To: Herbert Xu Cc: Linux Crypto Mailing List Subject: Re: [PATCH] crypto: lib/utils - Move utilities into new header Message-ID: <20230328174038.GA890@sol.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Mar 24, 2023 at 05:59:38PM +0800, Herbert Xu wrote: > The utilities have historically resided in algapi.h as they were > first used internally before being exported. Move them into a > new header file so external users don't see internal API details. > > Signed-off-by: Herbert Xu > --- > > include/crypto/algapi.h | 63 ----------------------------------------- > include/crypto/utils.h | 73 ++++++++++++++++++++++++++++++++++++++++++++++++ > lib/crypto/utils.c | 2 - > 3 files changed, 75 insertions(+), 63 deletions(-) > Thanks for doing this! There are other files in lib/crypto/ that include currently. It seems they should be changed to include instead? - Eric