From: Mario Limonciello <mario.limonciello@amd.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>
Cc: "Held Felix" <Felix.Held@amd.com>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
"Mark Hasemeyer" <markhas@chromium.org>,
"Grzegorz Bernacki" <gjb@semihalf.com>,
"Jan Dąbroś" <jsd@semihalf.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org
Subject: [PATCH v8 3/6] crypto: ccp: Return doorbell status code as an argument
Date: Mon, 3 Apr 2023 13:32:12 -0500 [thread overview]
Message-ID: <20230403183216.3493-4-mario.limonciello@amd.com> (raw)
In-Reply-To: <20230403183216.3493-1-mario.limonciello@amd.com>
If the doorbell failed to ring we return -EIO, but the caller can't
determine why it failed. Pass the reason for the failure in an
argument for caller to investigate.
Suggested-by: Mark Hasemeyer <markhas@chromium.org>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Mark Hasemeyer <markhas@chromium.org>
Tested-by: Mark Hasemeyer <markhas@chromium.org>
---
drivers/crypto/ccp/platform-access.c | 4 +++-
include/linux/psp-platform-access.h | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/ccp/platform-access.c b/drivers/crypto/ccp/platform-access.c
index 1cc154a1c6ab..48f59ae91692 100644
--- a/drivers/crypto/ccp/platform-access.c
+++ b/drivers/crypto/ccp/platform-access.c
@@ -132,7 +132,7 @@ int psp_send_platform_access_msg(enum psp_platform_access_msg msg,
}
EXPORT_SYMBOL_GPL(psp_send_platform_access_msg);
-int psp_ring_platform_doorbell(int msg)
+int psp_ring_platform_doorbell(int msg, u32 *result)
{
struct psp_device *psp = psp_get_master_device();
struct psp_platform_access_device *pa_dev;
@@ -164,6 +164,8 @@ int psp_ring_platform_doorbell(int msg)
val = FIELD_GET(PSP_CMDRESP_STS, ioread32(cmd));
if (val) {
+ if (result)
+ *result = val;
ret = -EIO;
goto unlock;
}
diff --git a/include/linux/psp-platform-access.h b/include/linux/psp-platform-access.h
index 89df4549fada..1b661341d8f3 100644
--- a/include/linux/psp-platform-access.h
+++ b/include/linux/psp-platform-access.h
@@ -45,9 +45,9 @@ int psp_send_platform_access_msg(enum psp_platform_access_msg, struct psp_reques
* -%EBUSY: mailbox in recovery or in use
* -%ENODEV: driver not bound with PSP device
* -%ETIMEDOUT: request timed out
- * -%EIO: unknown error (see kernel log)
+ * -%EIO: error will be stored in result argument
*/
-int psp_ring_platform_doorbell(int msg);
+int psp_ring_platform_doorbell(int msg, u32 *result);
/**
* psp_check_platform_access_status() - Checks whether platform features is ready
--
2.34.1
next prev parent reply other threads:[~2023-04-03 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 18:32 [PATCH v8 0/6] Use CCP driver to handle PSP I2C arbitration Mario Limonciello
2023-04-03 18:32 ` [PATCH v8 1/6] crypto: ccp: Drop extra doorbell checks Mario Limonciello
2023-04-03 18:32 ` [PATCH v8 2/6] crypto: ccp: Bump up doorbell debug message to error Mario Limonciello
2023-04-03 18:32 ` Mario Limonciello [this message]
2023-04-03 18:32 ` [PATCH v8 4/6] crypto: ccp: Use lower 8 bytes to communicate with doorbell command register Mario Limonciello
2023-04-06 6:42 ` [PATCH v8 0/6] Use CCP driver to handle PSP I2C arbitration Wolfram Sang
2023-04-06 11:58 ` Mario Limonciello
2023-04-07 6:18 ` Wolfram Sang
2023-04-12 16:28 ` Limonciello, Mario
2023-04-14 11:05 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230403183216.3493-4-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Felix.Held@amd.com \
--cc=davem@davemloft.net \
--cc=gjb@semihalf.com \
--cc=herbert@gondor.apana.org.au \
--cc=john.allen@amd.com \
--cc=jsd@semihalf.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markhas@chromium.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox