From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 582A1C77B6C for ; Tue, 4 Apr 2023 21:27:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236230AbjDDV1l (ORCPT ); Tue, 4 Apr 2023 17:27:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229748AbjDDV1k (ORCPT ); Tue, 4 Apr 2023 17:27:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2D0A19BD; Tue, 4 Apr 2023 14:27:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 54B15634D1; Tue, 4 Apr 2023 21:27:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B025C433D2; Tue, 4 Apr 2023 21:27:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680643658; bh=bnJKYz7hgPr/gLu9S3FIC84wJhIzGVDpgOk24YANfKs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LIS/Q3mMub53GidGokOOeIViscA6jtGr1sMYGURfpsX6xV/m1BRPYyhxQXt4EeWgb eMSWubsJ0xf8gWtuZ1vkQQOzfrfaTA4Gi6zpiab4zLL22ZxKX7aOsg78Ow8LVEtc4k K/ljs9ow2aZhlwj5+m5qJ1mHt9/8fTm7MnjigqmrMkMgQAjxmACuLN6tenc2H8vYU2 LefxSUuTSHHbJnGPnTeUhILZVEYCgjbLH5ol58YxddtBaxQFhVZzIjY2AeEOyEXtJI tl0kRwvht81sb86zIZLXOlfOktUYrfjxCcZs1lWrSWcW4a1GvpmP7QSASSBRxBBMS2 hmfTXggrYq5rQ== Date: Tue, 4 Apr 2023 22:27:30 +0100 From: Conor Dooley To: Sunil V L Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org, platform-driver-x86@vger.kernel.org, llvm@lists.linux.dev, "Rafael J . Wysocki" , "Rafael J . Wysocki" , Tom Rix , Weili Qian , Herbert Xu , Jonathan Corbet , Marc Zyngier , Daniel Lezcano , Andrew Jones , Albert Ou , Mark Gross , Hans de Goede , Paul Walmsley , Thomas Gleixner , Nathan Chancellor , Nick Desaulniers , Zhou Wang , Palmer Dabbelt , Len Brown , Maximilian Luz , "David S . Miller" Subject: Re: [PATCH V4 17/23] clocksource/timer-riscv: Add ACPI support Message-ID: <20230404-ammonium-cradle-a5bb0e4d4d3e@spud> References: <20230404182037.863533-1-sunilvl@ventanamicro.com> <20230404182037.863533-18-sunilvl@ventanamicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sQmAUn5NMdxQBCz+" Content-Disposition: inline In-Reply-To: <20230404182037.863533-18-sunilvl@ventanamicro.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org --sQmAUn5NMdxQBCz+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 04, 2023 at 11:50:31PM +0530, Sunil V L wrote: > Initialize the timer driver based on RHCT table on ACPI based > platforms. >=20 > Currently, ACPI doesn't support a flag to indicate that the > timer interrupt can wake up the cpu irrespective of its > power state. It will be added in future update. >=20 > Signed-off-by: Sunil V L > Acked-by: Rafael J. Wysocki > Reviewed-by: Andrew Jones My only comment on v3 was about the commit message & mentioning why there was no handling of the timer's ability to wake the cpu, so: Reviewed-by: Conor Dooley Thanks, Conor. > --- > drivers/clocksource/timer-riscv.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/drivers/clocksource/timer-riscv.c b/drivers/clocksource/time= r-riscv.c > index cecc4662293b..da3071b387eb 100644 > --- a/drivers/clocksource/timer-riscv.c > +++ b/drivers/clocksource/timer-riscv.c > @@ -10,6 +10,7 @@ > =20 > #define pr_fmt(fmt) "riscv-timer: " fmt > =20 > +#include > #include > #include > #include > @@ -207,3 +208,13 @@ static int __init riscv_timer_init_dt(struct device_= node *n) > } > =20 > TIMER_OF_DECLARE(riscv_timer, "riscv", riscv_timer_init_dt); > + > +#ifdef CONFIG_ACPI > +static int __init riscv_timer_acpi_init(struct acpi_table_header *table) > +{ > + return riscv_timer_init_common(); > +} > + > +TIMER_ACPI_DECLARE(aclint_mtimer, ACPI_SIG_RHCT, riscv_timer_acpi_init); > + > +#endif > --=20 > 2.34.1 >=20 >=20 > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv --sQmAUn5NMdxQBCz+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZCyWQgAKCRB4tDGHoIJi 0rT7AQCGUlB0daUlvZlotXE9AX4dUyeEfJS6O7vxjF94PE3b8QEAib+YSnkdmpOM ROSIWdBZztUmg+3YEDkEHx8u7yv+GAE= =n76y -----END PGP SIGNATURE----- --sQmAUn5NMdxQBCz+--